Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3271427pxb; Sun, 7 Feb 2021 03:51:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJy3TTefEgL0r1zVgSeDC3DVDcla/i+3wTKKXJCpwYoschyGGzpD1DuK7iN37Dts35PA67P4 X-Received: by 2002:a05:6402:2690:: with SMTP id w16mr12463802edd.304.1612698706733; Sun, 07 Feb 2021 03:51:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612698706; cv=none; d=google.com; s=arc-20160816; b=fSzsRY1f/ahV2WGgqfAjuSQY8/NnrunrADSeIoViHE7d0/VFLLd98x9edHe+z5plSb gJZAiFnHqPK8AjQa2SFUDV+zbq6SqAddi5L1EpaxZPJ9/nEw0dH3k1YSuE5WNba/omvD 0paRNNanb4v1i0Mlg7Mb8LRasrcVGVPvsM64x4PSGcyP6SFe35vYcf3pgAKUgmof0749 aJM1P2O9xlyDx4AbcchkrbLtaydqdEE0q7TzZk9gvok7jZpdcIeLrOALNhBWa3SYAjef lHe8d9Zjz5d4JS5rxUfEnnA+9l2lbuGRgFSX00wY++hqdNFUhTqvACGmQKwJa//tKOjg E//w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=2IDVJkC4c2majruHXRRqJKeHffA3UckBpZZzNfUoOzs=; b=voqjXO5dndo/whlWcc3KlHd9RhzZFpvlhFz0zVqgpn3z9WIivUGrOUre3akIgGHJGS 3ja4BQeeVNMOqnVHGUtMTVijUiM67pK1qU0eotUVAA/YJSSUrxl4/Y7E7zOEr7GeXaIT EjA1BOSSyR4m70PLnXj+daYRI5CpaXzVdrHKOieV0Ykbobwm75oAWKxEEJOs+cIlbQEj 72pAPHalQAOeAchHQOP7NmeFvPV1AJjMhVVUSPgCZkSikbQfAtWfb47qjR9iC9PIkg7P 4sxWg2BBsKwcBAGsNNCywVpfnBKIr4Byk4hLMPbs7tm0xMoSvQGH9488O+rJTOJGeeO7 pnRQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hs14si9904030ejc.159.2021.02.07.03.51.23; Sun, 07 Feb 2021 03:51:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229767AbhBGLsw (ORCPT + 99 others); Sun, 7 Feb 2021 06:48:52 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:12453 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229835AbhBGLlU (ORCPT ); Sun, 7 Feb 2021 06:41:20 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4DYRxV1fxrzjJmF; Sun, 7 Feb 2021 19:38:38 +0800 (CST) Received: from localhost.localdomain (10.67.165.24) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.498.0; Sun, 7 Feb 2021 19:39:36 +0800 From: Xiaofei Tan To: , CC: , , , Xiaofei Tan Subject: [PATCH for-next 28/32] scsi: sgiwd93: Replace spin_lock_irqsave with spin_lock in hard IRQ Date: Sun, 7 Feb 2021 19:36:59 +0800 Message-ID: <1612697823-8073-29-git-send-email-tanxiaofei@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1612697823-8073-1-git-send-email-tanxiaofei@huawei.com> References: <1612697823-8073-1-git-send-email-tanxiaofei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is redundant to do irqsave and irqrestore in hardIRQ context, where it has been in a irq-disabled context. Signed-off-by: Xiaofei Tan --- drivers/scsi/sgiwd93.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/sgiwd93.c b/drivers/scsi/sgiwd93.c index cf1030c..21165bd 100644 --- a/drivers/scsi/sgiwd93.c +++ b/drivers/scsi/sgiwd93.c @@ -53,11 +53,10 @@ struct hpc_chunk { static irqreturn_t sgiwd93_intr(int irq, void *dev_id) { struct Scsi_Host * host = dev_id; - unsigned long flags; - spin_lock_irqsave(host->host_lock, flags); + spin_lock(host->host_lock); wd33c93_intr(host); - spin_unlock_irqrestore(host->host_lock, flags); + spin_unlock(host->host_lock); return IRQ_HANDLED; } -- 2.8.1