Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3271489pxb; Sun, 7 Feb 2021 03:51:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJzeaMMTmWpCd4crc5kW2GEGAIzlgusTMY0ixHo4XHNEh2gc1nCv3bTu4LYbAFtuxNaoFK28 X-Received: by 2002:a05:6402:c8e:: with SMTP id cm14mr5625131edb.6.1612698716142; Sun, 07 Feb 2021 03:51:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612698716; cv=none; d=google.com; s=arc-20160816; b=rJNB7jqRGclpa79Evzz/yyIYxQxBDYjvDUhNO53NZan80hBaUA1h3lt+nQvIFwVwWx Zy9i7cZ1ROS2USAYdY97DpABhgdSWaayV/ZI+g+C6Fn5HAUcuS2BX64bGp8Nfxy9KCxK H0TR5MGUc/YbEhy4QnJ6XFIVWvseaPqbwe/xnkzpOnpdrne1SIHm8Of1j9VhAcug/UtE MePjS7Od6ZfcBtaS2hfEZRzN3jcEyz4XpXkyb0lSm5IxpPHsDspR0pTaNlQpW4J44WgX oVu1FQKz5QDIuy0WL8UnC3LT5zNdkTvtO/d0LB1U5cqPtjZBrWdWpP5SrWGzSl5HwVZ6 i3gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=yF74D9RTFr/GURoUiybIwHww+hy0Ry9fFlTNdFjn/EQ=; b=N9CY+gpou8DXcC/vA/04x8hZ4hOyzhFB14rhPCMqEP11yjiTuPIg/1NNmMJp98904Y FrqwdY4UWhFSjpgCE5FeQ8Z1VEeqxLefuMhwNg5MIY7tTxqg+zESaF8+C1slBukM8Ceh I3rjcvHlVPsLfhUP5TNkueIa0+I1XHrQOGPSJ58Fofqt4/rPApb5T5OJJalmrypdGonn sKdgRfAV9bU4egJAei0aO2t7OkEVX0CTQuLmPhZRRbil/SocEJ5Gi1QHjWooCG37W3Cc VeTSeYHzNE/APfY9EIkVy8WRVW3y1gONsow+zTDQ+Rf9SOBA6rPYQTVedInnCnwVRnPn KT6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bi18si10053008edb.309.2021.02.07.03.51.33; Sun, 07 Feb 2021 03:51:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229703AbhBGLuy (ORCPT + 99 others); Sun, 7 Feb 2021 06:50:54 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:12454 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229845AbhBGLlV (ORCPT ); Sun, 7 Feb 2021 06:41:21 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4DYRxV26cvzjJmM; Sun, 7 Feb 2021 19:38:38 +0800 (CST) Received: from localhost.localdomain (10.67.165.24) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.498.0; Sun, 7 Feb 2021 19:39:34 +0800 From: Xiaofei Tan To: , CC: , , , Xiaofei Tan Subject: [PATCH for-next 21/32] scsi: myrs: Replace spin_lock_irqsave with spin_lock in hard IRQ Date: Sun, 7 Feb 2021 19:36:52 +0800 Message-ID: <1612697823-8073-22-git-send-email-tanxiaofei@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1612697823-8073-1-git-send-email-tanxiaofei@huawei.com> References: <1612697823-8073-1-git-send-email-tanxiaofei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is redundant to do irqsave and irqrestore in hardIRQ context, where it has been in a irq-disabled context. Signed-off-by: Xiaofei Tan --- drivers/scsi/myrs.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/scsi/myrs.c b/drivers/scsi/myrs.c index 4adf9de..59379fc 100644 --- a/drivers/scsi/myrs.c +++ b/drivers/scsi/myrs.c @@ -2615,9 +2615,8 @@ static irqreturn_t DAC960_GEM_intr_handler(int irq, void *arg) struct myrs_hba *cs = arg; void __iomem *base = cs->io_base; struct myrs_stat_mbox *next_stat_mbox; - unsigned long flags; - spin_lock_irqsave(&cs->queue_lock, flags); + spin_lock(&cs->queue_lock); DAC960_GEM_ack_intr(base); next_stat_mbox = cs->next_stat_mbox; while (next_stat_mbox->id > 0) { @@ -2654,7 +2653,7 @@ static irqreturn_t DAC960_GEM_intr_handler(int irq, void *arg) } } cs->next_stat_mbox = next_stat_mbox; - spin_unlock_irqrestore(&cs->queue_lock, flags); + spin_unlock(&cs->queue_lock); return IRQ_HANDLED; } @@ -2865,9 +2864,8 @@ static irqreturn_t DAC960_BA_intr_handler(int irq, void *arg) struct myrs_hba *cs = arg; void __iomem *base = cs->io_base; struct myrs_stat_mbox *next_stat_mbox; - unsigned long flags; - spin_lock_irqsave(&cs->queue_lock, flags); + spin_lock(&cs->queue_lock); DAC960_BA_ack_intr(base); next_stat_mbox = cs->next_stat_mbox; while (next_stat_mbox->id > 0) { @@ -2904,7 +2902,7 @@ static irqreturn_t DAC960_BA_intr_handler(int irq, void *arg) } } cs->next_stat_mbox = next_stat_mbox; - spin_unlock_irqrestore(&cs->queue_lock, flags); + spin_unlock(&cs->queue_lock); return IRQ_HANDLED; } @@ -3115,9 +3113,8 @@ static irqreturn_t DAC960_LP_intr_handler(int irq, void *arg) struct myrs_hba *cs = arg; void __iomem *base = cs->io_base; struct myrs_stat_mbox *next_stat_mbox; - unsigned long flags; - spin_lock_irqsave(&cs->queue_lock, flags); + spin_lock(&cs->queue_lock); DAC960_LP_ack_intr(base); next_stat_mbox = cs->next_stat_mbox; while (next_stat_mbox->id > 0) { @@ -3154,7 +3151,7 @@ static irqreturn_t DAC960_LP_intr_handler(int irq, void *arg) } } cs->next_stat_mbox = next_stat_mbox; - spin_unlock_irqrestore(&cs->queue_lock, flags); + spin_unlock(&cs->queue_lock); return IRQ_HANDLED; } -- 2.8.1