Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3271761pxb; Sun, 7 Feb 2021 03:52:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJyrXV+eWKz5go4wZSOlCVZQm9ek81paVUBiCPQECUKus8B1oSB+Hm2u3fIKt210ovb02aFz X-Received: by 2002:a17:906:6057:: with SMTP id p23mr12544286ejj.281.1612698752170; Sun, 07 Feb 2021 03:52:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612698752; cv=none; d=google.com; s=arc-20160816; b=Tp1WZc6X1Gdl5mXVmlDBP87DvbYIn9c8/u6ErIDFM8R2qCeaMHOfo7W2Sg8pq0UAdz fuNUCek7xqN0P/7mML6s0+5FFIILWntY1VrCNFA993NZJmwOnK0cjI2EzjH055iGrNKv P/bH+0n7yJ5yFoMnQlKYfPJokw2+Azs0hNKfUSBI0IUdw1ovpKo9vmVz6DPVa+4htHFg RlfvRhhlvBMNKbanNStvCV2dQVHhD4KAubenYYRhPOUyD6rp76MdsNNAEQmfznpMC+sc oSaAagTUJdDelyW8l4rAVyxCZtg7v0kzCoZQIkTgOyExSLJTwEYrvZd0rL7kSYWx8ziu v+Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=vP2jFnNb9jFp8zHQB2jvpU/bbcsOGm8STcoW4Nh+LA0=; b=ceRkGESJNIYa4zXr8976iFqNjbwXr6aO5Px/LxKCbvqhCZ23MqoV9PwfrpGBKIwM2m CqMfr68wWBJKiHmI0eaALXoPF45bTgLCWGtogpMxsCrHe0nVsekR9zv/s2xV3ij/U4Gu ukYQ3wTC2GCckqIiy2rkx7hW8Qu473eSOAdRyjFcwL/R89B/YP9J5fENVTBLOq6z62Ln Kw1jKd56SY6kW2kJh5nY35xj8IRUg6ItCANaYGYBYQEBthVPrWH/wEXFUorqFYcfoXCV BduiPCOXJnBS0tO5tVDPLV4Ps9rwCb0Awe8mh2I9n/wOvCJzsCgb+7ZWaHykPO8H8CT0 QX2w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bz20si6391645ejc.101.2021.02.07.03.52.09; Sun, 07 Feb 2021 03:52:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230020AbhBGLvd (ORCPT + 99 others); Sun, 7 Feb 2021 06:51:33 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:12455 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229843AbhBGLlV (ORCPT ); Sun, 7 Feb 2021 06:41:21 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4DYRxV2LNDzjJmN; Sun, 7 Feb 2021 19:38:38 +0800 (CST) Received: from localhost.localdomain (10.67.165.24) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.498.0; Sun, 7 Feb 2021 19:39:33 +0800 From: Xiaofei Tan To: , CC: , , , Xiaofei Tan Subject: [PATCH for-next 19/32] scsi: mvumi: Replace spin_lock_irqsave with spin_lock in hard IRQ Date: Sun, 7 Feb 2021 19:36:50 +0800 Message-ID: <1612697823-8073-20-git-send-email-tanxiaofei@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1612697823-8073-1-git-send-email-tanxiaofei@huawei.com> References: <1612697823-8073-1-git-send-email-tanxiaofei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is redundant to do irqsave and irqrestore in hardIRQ context, where it has been in a irq-disabled context. Signed-off-by: Xiaofei Tan --- drivers/scsi/mvumi.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/mvumi.c b/drivers/scsi/mvumi.c index 71b6a1f..b36164c 100644 --- a/drivers/scsi/mvumi.c +++ b/drivers/scsi/mvumi.c @@ -1790,11 +1790,10 @@ static void mvumi_handle_clob(struct mvumi_hba *mhba) static irqreturn_t mvumi_isr_handler(int irq, void *devp) { struct mvumi_hba *mhba = (struct mvumi_hba *) devp; - unsigned long flags; - spin_lock_irqsave(mhba->shost->host_lock, flags); + spin_lock(mhba->shost->host_lock); if (unlikely(mhba->instancet->clear_intr(mhba) || !mhba->global_isr)) { - spin_unlock_irqrestore(mhba->shost->host_lock, flags); + spin_unlock(mhba->shost->host_lock); return IRQ_NONE; } @@ -1815,7 +1814,7 @@ static irqreturn_t mvumi_isr_handler(int irq, void *devp) mhba->isr_status = 0; if (mhba->fw_state == FW_STATE_STARTED) mvumi_handle_clob(mhba); - spin_unlock_irqrestore(mhba->shost->host_lock, flags); + spin_unlock(mhba->shost->host_lock); return IRQ_HANDLED; } -- 2.8.1