Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Stefan Chulski <stefanc@marvell.com>
To:     Baruch Siach <baruch@tkos.co.il>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        Yan Markman <ymarkman@marvell.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "atenart@kernel.org" <atenart@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        Nadav Haklai <nadavh@marvell.com>,
        "rmk+kernel@armlinux.org.uk" <rmk+kernel@armlinux.org.uk>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "mw@semihalf.com" <mw@semihalf.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
        "sebastian.hesselbarth@gmail.com" <sebastian.hesselbarth@gmail.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [EXT] Re: [RESEND PATCH v8 net-next 03/15] net: mvpp2: add CM3
 SRAM memory map
Thread-Topic: [EXT] Re: [RESEND PATCH v8 net-next 03/15] net: mvpp2: add CM3
 SRAM memory map
Thread-Index: AQHW/SobMD3vDu1MAkO+p8Aai21QfKpMgmUAgAAZ2bA=
Date:   Sun, 7 Feb 2021 12:21:42 +0000
Message-ID: <CO6PR18MB38731B7D025AE9202104E707B0B09@CO6PR18MB3873.namprd18.prod.outlook.com>
References: <1612685964-21890-1-git-send-email-stefanc@marvell.com>
 <1612685964-21890-4-git-send-email-stefanc@marvell.com>
 <87mtwgxik1.fsf@tarshish>
In-Reply-To: <87mtwgxik1.fsf@tarshish>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d52fa8bf-a998-4958-76d6-08d8cb62edde
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2021 12:21:42.9942
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IUOlGmK7FuTwqzd2VkTFRcCdQTW6Mj3TG0Sy9F+PLfxFwytDC+VpQZhXSZ1PV+Loc7snVHxHRs/qx3lOw0nQpw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB3905
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737
 definitions=2021-02-07_06:2021-02-05,2021-02-07 signatures=0
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> >  }
> >
> > +static int mvpp2_get_sram(struct platform_device *pdev,
> > +			  struct mvpp2 *priv)
> > +{
> > +	struct device_node *dn =3D pdev->dev.of_node;
> > +	static bool defer_once;
> > +	struct resource *res;
> > +
> > +	if (has_acpi_companion(&pdev->dev)) {
> > +		res =3D platform_get_resource(pdev, IORESOURCE_MEM, 2);
> > +		if (!res) {
> > +			dev_warn(&pdev->dev, "ACPI is too old, Flow control
> not supported\n");
> > +			return 0;
> > +		}
> > +		priv->cm3_base =3D devm_ioremap_resource(&pdev->dev,
> res);
> > +		if (IS_ERR(priv->cm3_base))
> > +			return PTR_ERR(priv->cm3_base);
> > +	} else {
> > +		priv->sram_pool =3D of_gen_pool_get(dn, "cm3-mem", 0);
> > +		if (!priv->sram_pool) {
> > +			if (!defer_once) {
> > +				defer_once =3D true;
> > +				/* Try defer once */
> > +				return -EPROBE_DEFER;
> > +			}
> > +			dev_warn(&pdev->dev, "DT is too old, Flow control
> not
> > +supported\n");
>=20
> This warning will show on every DT system with no cm3-mem property,
> right?
>=20

All DT system would has cm3-mem property if " add CM3 SRAM memory to cp11x =
ethernet device tree " patch applied.
This is also only warning message, without any functional impact.

Regards,
Stefan.=20