Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932255AbWIVDqg (ORCPT ); Thu, 21 Sep 2006 23:46:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932256AbWIVDqg (ORCPT ); Thu, 21 Sep 2006 23:46:36 -0400 Received: from smtp.osdl.org ([65.172.181.4]:9858 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S932255AbWIVDqf (ORCPT ); Thu, 21 Sep 2006 23:46:35 -0400 Date: Thu, 21 Sep 2006 20:46:29 -0700 From: Andrew Morton To: KAMEZAWA Hiroyuki Cc: kmannth@us.ibm.com, linux-kernel@vger.kernel.org, clameter@engr.sgi.com Subject: Re: [BUG] i386 2.6.18 cpu_up: attempt to bring up CPU 4 failed : kernel BUG at mm/slab.c:2698! Message-Id: <20060921204629.49caa95f.akpm@osdl.org> In-Reply-To: <20060922123045.d7258e13.kamezawa.hiroyu@jp.fujitsu.com> References: <1158884252.5657.38.camel@keithlap> <20060921174134.4e0d30f2.akpm@osdl.org> <1158888843.5657.44.camel@keithlap> <20060922112427.d5f3aef6.kamezawa.hiroyu@jp.fujitsu.com> <20060921200806.523ce0b2.akpm@osdl.org> <20060922123045.d7258e13.kamezawa.hiroyu@jp.fujitsu.com> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1179 Lines: 34 On Fri, 22 Sep 2006 12:30:45 +0900 KAMEZAWA Hiroyuki wrote: > Before kfree(), we should check zone_pcp() is not boot_pageset[]. > > Signed-Off-By KAMEZAWA Hiroyuki > > Index: linux-2.6.18/mm/page_alloc.c > =================================================================== > --- linux-2.6.18.orig/mm/page_alloc.c 2006-09-20 12:42:06.000000000 +0900 > +++ linux-2.6.18/mm/page_alloc.c 2006-09-22 12:22:03.000000000 +0900 > @@ -1844,9 +1844,11 @@ > > for_each_zone(zone) { > struct per_cpu_pageset *pset = zone_pcp(zone, cpu); > - > - zone_pcp(zone, cpu) = NULL; > - kfree(pset); > + /* When canceled, zone_pcp still points to boot_pageset[] */ > + if (zone_pcp(zone, cpu) != &boot_pageset[cpu]) { > + zone_pcp(zone, cpu) = NULL; > + kfree(pset); > + } > } > } Oh, I see what you mean. Oh well, zeroing them all out in process_zones() will work. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/