Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210207035024.69095-1-colton@boothsoftware.ca>
In-Reply-To: <20210207035024.69095-1-colton@boothsoftware.ca>
From:   "Jason A. Donenfeld" <Jason@zx2c4.com>
Date:   Sun, 7 Feb 2021 16:41:20 +0100
Message-ID: <CAHmME9oa+yAJikmSysEZCEPftTwxFyftiO3iS7wGeCd=nd75Gg@mail.gmail.com>
Subject: Re: [PATCH] Input: synaptic - reverting dcb00fc799dc03fd320e123e4c81b3278c763ea5
 because it breaks the touchpad for one guy on Reddit.
To:     colton@boothsoftware.ca
Cc:     Dmitry Torokhov <dmitry.torokhov@gmail.com>, colton@boothlinux.ca,
        Lyude Paul <lyude@redhat.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Lee Jones <lee.jones@linaro.org>,
        Vincent Huang <vincent.huang@tw.synaptics.com>,
        Dennis Kadioglu <denk@eclipso.email>,
        Yussuf Khalil <dev@pp3345.net>, Ilya Katsnelson <me@0upti.me>,
        Gaurav Agrawal <agrawalgaurav@gnome.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Feb 7, 2021 at 5:00 AM Colton Booth <colton@boothsoftware.ca> wrote:
>
> I can't test myself since I don't have the correct hardware, BUT this change seems to work for him. I'm thinking he has an early version of the X1E which may use slightly different trackpad revision.
>
> Signed-off-by: Colton Booth <colton@boothsoftware.ca>
> ---
>  drivers/input/mouse/synaptics.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index ffad142801b3..2d3f03921dbc 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -179,9 +179,7 @@ static const char * const smbus_pnp_ids[] = {
>         "LEN0093", /* T480 */
>         "LEN0096", /* X280 */
>         "LEN0097", /* X280 -> ALPS trackpoint */
> -       "LEN0099", /* X1 Extreme Gen 1 / P1 Gen 1 */
>         "LEN009b", /* T580 */
> -       "LEN0402", /* X1 Extreme Gen 2 / P1 Gen 2 */
>         "LEN200f", /* T450s */
>         "LEN2044", /* L470  */
>         "LEN2054", /* E480 */

This removes two totally separate models for "one guy on Reddit". Does
he have two computers that coincidentally have the same problem? Any
details about what that problem is so that we can assess it?

Jason