Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Stefan Chulski <stefanc@marvell.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        Nadav Haklai <nadavh@marvell.com>,
        Yan Markman <ymarkman@marvell.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        "mw@semihalf.com" <mw@semihalf.com>,
        "rmk+kernel@armlinux.org.uk" <rmk+kernel@armlinux.org.uk>,
        "atenart@kernel.org" <atenart@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "sebastian.hesselbarth@gmail.com" <sebastian.hesselbarth@gmail.com>,
        "gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [EXT] Re: [RESEND PATCH v8 net-next 03/15] net: mvpp2: add CM3
 SRAM memory map
Thread-Topic: [EXT] Re: [RESEND PATCH v8 net-next 03/15] net: mvpp2: add CM3
 SRAM memory map
Thread-Index: AQHW/SobMD3vDu1MAkO+p8Aai21QfKpM5cqAgAAA5yA=
Date:   Sun, 7 Feb 2021 16:51:53 +0000
Message-ID: <CO6PR18MB387374A4B8FA0FD1213EDAE6B0B09@CO6PR18MB3873.namprd18.prod.outlook.com>
References: <1612685964-21890-1-git-send-email-stefanc@marvell.com>
 <1612685964-21890-4-git-send-email-stefanc@marvell.com>
 <YCAYL+jEVijKQqaa@lunn.ch>
In-Reply-To: <YCAYL+jEVijKQqaa@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 79d589d1-646f-4313-3c31-08d8cb88ac11
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2021 16:51:53.4721
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GN/yITzNyO5M5vYOxXfr2tCi3y04uZ30HJjiZICR0wWw+T+356sLwSVolnVy6Ht7Y67WHA4TpCD2IWCzJPfAMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR18MB3532
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737
 definitions=2021-02-07_08:2021-02-05,2021-02-07 signatures=0
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > +		priv->sram_pool =3D of_gen_pool_get(dn, "cm3-mem", 0);
> > +		if (!priv->sram_pool) {
> > +			if (!defer_once) {
> > +				defer_once =3D true;
> > +				/* Try defer once */
> > +				return -EPROBE_DEFER;
> > +			}
> > +			dev_warn(&pdev->dev, "DT is too old, Flow control
> not supported\n");
> > +			return -ENOMEM;
> > +		}
> > +		/* cm3_base allocated with offset zero into the SRAM since
> mapping size
> > +		 * is equal to requested size.
> > +		 */
> > +		priv->cm3_base =3D (void __iomem *)gen_pool_alloc(priv-
> >sram_pool,
> > +
> 	MSS_SRAM_SIZE);
> > +		if (!priv->cm3_base)
> > +			return -ENOMEM;
> > +	}
>=20
> For v2 i asked:
>=20
> > I'm wondering if using a pool even makes sense. The ACPI case just
> > ioremap() the memory region. Either this memory is dedicated, and then
> > there is no need to use a pool, or the memory is shared, and at some
> > point the ACPI code is going to run into problems when some other
> > driver also wants access.
>=20
> There was never an answer to this.

Sorry probably missed this. Currently this memory not shared and I can just=
 ioremap same way as in ACPI case.
In this case I can remove EPROBE_DEFER.

Thanks,
Stefan.