Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: F4ecqpHzXyXVhvB1E5A+/p+yRrsG3ASEK3LN1Fhgx+PPCO++XDRmPr0LjUaZo6eXTJmbTcOJBD
 Vl61n9TPHhDA==
IronPort-SDR: GMp86bEeNPC9zfjq7mQgUZq921VzzJ7oPwsuC1k1SoS1a6Et2e5NHtnwAr4RKzxEsq5HQuu05d
 TAW/pHZMg+uw==
From:   "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Winkler, Tomas" <tomas.winkler@intel.com>
CC:     "Usyskin, Alexander" <alexander.usyskin@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Coelho, Luciano" <luciano.coelho@intel.com>,
        "kvalo@codeaurora.org" <kvalo@codeaurora.org>
Subject: RE: [char-misc-next 6/6] mei: bus: add client dma interface
Thread-Topic: [char-misc-next 6/6] mei: bus: add client dma interface
Thread-Index: AQHW/JZ6zfy6g0Lzl0WlwNIsjRgFAKpLE28AgAAknRCAABmFgIABaTKAgAAIgICAAElxIA==
Date:   Sun, 7 Feb 2021 19:04:46 +0000
Message-ID: <SA0PR11MB4752FDA7D0500511C3FE3E43F2B09@SA0PR11MB4752.namprd11.prod.outlook.com>
References: <20210206144325.25682-1-tomas.winkler@intel.com>
 <20210206144325.25682-6-tomas.winkler@intel.com> <YB6sIi61X5p6Dq6y@kroah.com>
 <2a9b40090acd41438fc6b1d2fb49f38d@intel.com> <YB7EIciZrmBrEqUA@kroah.com>
 <8223112ef8504a31996c2c1bd386d1fe@intel.com> <YB/6QWo/e6UVsNuj@kroah.com>
In-Reply-To: <YB/6QWo/e6UVsNuj@kroah.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c4222fc-8e42-4327-ab33-08d8cb9b3c86
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2021 19:04:46.3715
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SXhpaluIr3I/1T0MIg1RvKSj89zZdOF5Ox2r/3ZsprDqkp+19OmWfn4myfih5XeM0yZPdNoHY1tne40qVZi1I1xhRxbzZQpDSpAJ3vfEMoQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3119
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Greg,

> On Sun, Feb 07, 2021 at 02:03:11PM +0000, Winkler, Tomas wrote:
> > >
> > > On Sat, Feb 06, 2021 at 03:04:34PM +0000, Winkler, Tomas wrote:
> > > > > On Sat, Feb 06, 2021 at 04:43:25PM +0200, Tomas Winkler wrote:
> > > > > > From: Alexander Usyskin <alexander.usyskin@intel.com>
> > > > > >
> > > > > > Expose the client dma mapping via mei client bus interface.
> > > > > >
> > > > > > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> > > > > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> > > > > > ---
> > > > > >  drivers/misc/mei/bus.c     | 46
> > > > > ++++++++++++++++++++++++++++++++++++++
> > > > > >  drivers/misc/mei/hw.h      |  5 +++++
> > > > > >  include/linux/mei_cl_bus.h |  3 +++
> > > > > >  3 files changed, 54 insertions(+)
> > > > > >
> > > > > > diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c
> > > > > > index
> > > > > > 34fb5e541fe5..d430710a5fe5 100644
> > > > > > --- a/drivers/misc/mei/bus.c
> > > > > > +++ b/drivers/misc/mei/bus.c
> > > > > > @@ -636,6 +636,52 @@ static void mei_cl_bus_vtag_free(struct
> > > > > mei_cl_device *cldev)
> > > > > >  	kfree(cl_vtag);
> > > > > >  }
> > > > > >
> > > > > > +void *mei_cldev_dma_map(struct mei_cl_device *cldev, u8
> > > > > > +buffer_id, size_t size) {
> > > > > > +	struct mei_device *bus;
> > > > > > +	struct mei_cl *cl;
> > > > > > +	int ret;
> > > > > > +
> > > > > > +	if (!cldev || !buffer_id || !size)
> > > > > > +		return ERR_PTR(-EINVAL);
> > > > > > +
> > > > > > +	if (!IS_ALIGNED(size, MEI_FW_PAGE_SIZE)) {
> > > > > > +		dev_err(&cldev->dev, "Map size should be aligned to
> %lu\n",
> > > > > > +			MEI_FW_PAGE_SIZE);
> > > > > > +		return ERR_PTR(-EINVAL);
> > > > > > +	}
> > > > > > +
> > > > > > +	cl =3D cldev->cl;
> > > > > > +	bus =3D cldev->bus;
> > > > > > +
> > > > > > +	mutex_lock(&bus->device_lock);
> > > > > > +	ret =3D mei_cl_dma_alloc_and_map(cl, NULL, buffer_id, size);
> > > > > > +	mutex_unlock(&bus->device_lock);
> > > > > > +	if (ret)
> > > > > > +		return ERR_PTR(ret);
> > > > > > +	return cl->dma.vaddr;
> > > > > > +}
> > > > > > +EXPORT_SYMBOL_GPL(mei_cldev_dma_map);
> > > > >
> > > > > Why are you exporting symbols without a user of them?
> > > > >
> > > > > That's a sure way to get them removed by someone right after
> > > > > this lands in the tree :)
> > > > >
> > > > > Please only add infrastructure for when you have a real user.
> > > > You are right,  the user is coming from wifi tree. We need merge
> > > > before
> > > they do.
> > > > If you prefer we can merge that all from the wifi tree.
> > >
> > > That wasn't documented well at all in your changelog comment :(
> > Note taken.
> > > It can go through whatever tree needs it.
> > If possible please merge our changes already here, and let the wifi guy=
s to
> finish their task in their tree, in their own time.
>=20
> I took some of these already, patches 1 and 6 I can't take as-is, sorry.

As Tomas said, 6 is needed by iwlwifi. I understand you want it to be route=
d through iwlwifi-next.git. I added Kalle so that he gets a heads up.
1 is not related to iwlwifi.