Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3669237pxb; Sun, 7 Feb 2021 18:30:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJzNkqYS3bm/8Tg87LnEs6Z8JVw5XYGXNahMXfSoReOc+1+RTPJXIwTdpf3jVIYLJnW7uoFZ X-Received: by 2002:a17:906:17c3:: with SMTP id u3mr14557259eje.304.1612751446656; Sun, 07 Feb 2021 18:30:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612751446; cv=none; d=google.com; s=arc-20160816; b=Hjr+m5ykpK0fYZs2xMCsLe8c75nWzIyej3jMlWdgbMTHRyBhnLoQPiT0mVSU4QAP/X U+BwRu0Ctx6D8OZiVT4XBBShWtdhYN79rwtS4L6C3zsBbNHqL1jtLS3GkpsaI+cSgwBo 0n1Ku/C0kD6tiEYS0DbLU0boXrp8UVZLfpFn8a3Eh8HqtasKV8QbHN7Rut7mVl7xu/Vi a8sY8z/W5p0gzyTifa1qkpuyy8u29Sx0HUPoQqOdmxFP0ZawCEOwSolLmh6nC0u43Mb8 /5KgUHRc29Pdx0A/SuJW7Wr/KWTJJExTcTuMpFSTL79LlU0eCqzAHtQ3c9v3A7XHiin7 F5ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=prVjlOxJgxegYr5WyW9Puejur2UOLsJUAHlf/hcHxi4=; b=p02z8j3OpdWKZajQ2VUmxKrHOvz72vNFeb4dh4zWblBiecnTd+XkYy/xuly5AX69oD +LpEEWdDI5QVqOYY43o70/6Q0JBgT0Xd/j0rqLGp0PqNeUKVsG41d83aE9kLYH/SvXt0 vrRxloMG6/gin9EM1IYdSs3IuPacw6z7K5+t3SBLTShAv6jo4i/xBSdaMO7bPCu/ujhA XB5aq9gac/dx59dOZ6UstqbjcK+MT2Grq+u8yDHHnevTRcieV82I2/Sc0JUQxEZXUNG7 FjnbrrMZWw2XqGv4Q7U8lwCSPRvQpdVC9ZTqb0oYhJGuhqCFNAxHrUVwCybdMv/eDxo1 qALg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=P3vCF0PG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cm5si10587067edb.479.2021.02.07.18.30.23; Sun, 07 Feb 2021 18:30:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=P3vCF0PG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229731AbhBHC3d (ORCPT + 99 others); Sun, 7 Feb 2021 21:29:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229611AbhBHC3b (ORCPT ); Sun, 7 Feb 2021 21:29:31 -0500 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15E3FC061788 for ; Sun, 7 Feb 2021 18:28:51 -0800 (PST) Received: by mail-lj1-x233.google.com with SMTP id c18so15106933ljd.9 for ; Sun, 07 Feb 2021 18:28:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=prVjlOxJgxegYr5WyW9Puejur2UOLsJUAHlf/hcHxi4=; b=P3vCF0PGHm1O1esy5AM5oRBJYOvhkYL9KaghBGfStowxVodRdE6aeYoKVs07gQqCRV /KDTE5iE1GBcC277I9pstoXCyEU29eULNB63ExV6UmFLrRdZgK8cat9bk3XBYQWEqBKZ /u53kzhG9DHRjLKqrk6f1wV8sTD2D+qeNK6tUSVqb8+zFZWF61kH4Xc8fRs9lLv3r3MI 6HdoVrX+/2iVx51pPmhaEOfLaGjMlZY73hR6+llJr0bs/KK4S8dT42noXnH9cMoNKDav oH6zlOgD5ZCAqGqOIFzXdtV42/msvCRIF4YGwFet67mFYidyVgIrsOpZ9fhTmaF0qdpd wr1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=prVjlOxJgxegYr5WyW9Puejur2UOLsJUAHlf/hcHxi4=; b=j6eZQuARfAYTmaEPXZrBbIlgujG8mTCpY8K9Fpe+cJzWTGdvhk/4hLQ1ZviLDKTdW4 ViRzRQ3sstrW9eTNTfIe+fQjFvyDXDno3S5czRPSBhZ1pSZuBGHhnaHRW9TM/VNmzdzp J4aZi8FaMFQWSd/0DnF9gEdzDLWuc7+lMVdhH+Qeb7SfFjp9AKKsl1hRgYlIfvqxMOwO 8MKgcRWyUAQq1G/h12cS9IBgWJFaBL7JFlacAK22E0dSAOASDk39f9JcJ9nX5l9NLoal B4Ad4rYbT6Tzw3UxAnTbGbn8yRvycrD6fjy7iJNafGEZ2FIT/8qGbUkJUXVphx9Lg2PW eGHA== X-Gm-Message-State: AOAM530zJvNRl5TFAzT3iH24KCnViOFaxMggKViZT0eHQLp3D9zxcJG6 I22pFtKnFR1m+fGQzqtWtGaBTw4U4fSztMHNd25j5Q== X-Received: by 2002:a2e:9801:: with SMTP id a1mr10029568ljj.122.1612751329278; Sun, 07 Feb 2021 18:28:49 -0800 (PST) MIME-Version: 1.0 References: <20210205182806.17220-1-hannes@cmpxchg.org> <20210205182806.17220-8-hannes@cmpxchg.org> In-Reply-To: <20210205182806.17220-8-hannes@cmpxchg.org> From: Shakeel Butt Date: Sun, 7 Feb 2021 18:28:37 -0800 Message-ID: Subject: Re: [PATCH 7/8] mm: memcontrol: consolidate lruvec stat flushing To: Johannes Weiner Cc: Andrew Morton , Tejun Heo , Michal Hocko , Roman Gushchin , Linux MM , Cgroups , LKML , Kernel Team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 5, 2021 at 10:28 AM Johannes Weiner wrote: > > There are two functions to flush the per-cpu data of an lruvec into > the rest of the cgroup tree: when the cgroup is being freed, and when > a CPU disappears during hotplug. The difference is whether all CPUs or > just one is being collected, but the rest of the flushing code is the > same. Merge them into one function and share the common code. > > Signed-off-by: Johannes Weiner Reviewed-by: Shakeel Butt BTW what about the lruvec stats? Why not convert them to rstat as well?