Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH V3 18/19] virtio_vdpa: don't warn when fail to disable vq
To:     "Michael S. Tsirkin" <mst@redhat.com>
Cc:     virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org, shahafs@mellanox.com,
        lulu@redhat.com, sgarzare@redhat.com, rdunlap@infradead.org
References: <20210104065503.199631-1-jasowang@redhat.com>
 <20210104065503.199631-19-jasowang@redhat.com>
 <20210205102442-mutt-send-email-mst@kernel.org>
From:   Jason Wang <jasowang@redhat.com>
Message-ID: <2911e3c2-84ff-006a-24ba-fb6aea9d25d5@redhat.com>
Date:   Mon, 8 Feb 2021 12:15:39 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20210205102442-mutt-send-email-mst@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk


On 2021/2/5 下午11:24, Michael S. Tsirkin wrote:
> On Mon, Jan 04, 2021 at 02:55:02PM +0800, Jason Wang wrote:
>> There's no guarantee that the device can disable a specific virtqueue
>> through set_vq_ready(). One example is the modern virtio-pci
>> device. So this patch removes the warning.
>>
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>
> Do we need the read as a kind of flush though?


The problem is that PCI forbids write 0 to queue_enable. So I'm not sure 
what kind of flush do we need here?

Thanks


>
>> ---
>>   drivers/virtio/virtio_vdpa.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c
>> index 4a9ddb44b2a7..e28acf482e0c 100644
>> --- a/drivers/virtio/virtio_vdpa.c
>> +++ b/drivers/virtio/virtio_vdpa.c
>> @@ -225,9 +225,8 @@ static void virtio_vdpa_del_vq(struct virtqueue *vq)
>>   	list_del(&info->node);
>>   	spin_unlock_irqrestore(&vd_dev->lock, flags);
>>   
>> -	/* Select and deactivate the queue */
>> +	/* Select and deactivate the queue (best effort) */
>>   	ops->set_vq_ready(vdpa, index, 0);
>> -	WARN_ON(ops->get_vq_ready(vdpa, index));
>>   
>>   	vring_del_virtqueue(vq);
>>   
>> -- 
>> 2.25.1