Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3803496pxb; Sun, 7 Feb 2021 23:59:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJx0gYSxzlPnMBYJYX61aDJJx7ZWFl4+V9rrRToqV6ebweMGX8cwMGQfVniQ9sRVah3RwU6+ X-Received: by 2002:a17:906:798:: with SMTP id l24mr15919433ejc.92.1612771144297; Sun, 07 Feb 2021 23:59:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612771144; cv=none; d=google.com; s=arc-20160816; b=fdxPLE3fra0zps8oYcmjdXAxjrHnEH7MiUo3SsbR09eL4rPVpEe0C+9wkIBL/4AGZ5 ZB9VfTtom/rcuoGi0kIov5K01zyHL/8Qippl6/kVbB65etEMt4lB+oBD909FwBUvFGkF p2ye0rd0pY7RFUbYPJfjRKEEbZk8rHyxaP+2tQ5ina3VQlYG+Tc68OH4C4H6ZQ9n++gB E7LJegKJ3uPfr8xN46YKGG4BcLb+oxJsJ2+Zsgg3LRNfhRjh09Lff2ydsnMJsHpz5Lg1 EKLEf2r83mgQnlxju7ITT83Gx3EZ/Ykn5mNAythUEncRDo3D20AhzlCt1yBheYekkZln 0IoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:message-id:in-reply-to :subject:cc:to:from:date; bh=xYyQRQ/j7paMv5pmD3xQMCNnOxItQiYJnUhIqUUpErU=; b=ixw3aBoBMA/cpMbmyX+E0LNH7o+S91tyyrlStO7K4k5Geu5noKAaWabn3p5MPkALSC z4FKGHW0dD2v92Id2c3NFctXvw3NNbvWi2jryRHEXPuhJ+FQI/TJJSQFMoRRnawpYDlE mTKjy9z8ns/YN7VSMY0SSOfElfJA0ASoeMn/RVo1wvSPI+mttR/ZTgI3mRCGJsbud8Rs n4eGI0HNxKEvmuJXeGYYyooK1fF78QVcoJHjdlEwgf/6XEnZkR+XTJGMVdnCOHWEXgdz TQkBG51DAIseTJdf59wdhDGjcqtEWGFxAtmSST/aH8G+axiO6pH78fHElMh5OT7727Nx u8cg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a10si10986034ejr.689.2021.02.07.23.58.41; Sun, 07 Feb 2021 23:59:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230137AbhBHH5x (ORCPT + 99 others); Mon, 8 Feb 2021 02:57:53 -0500 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:54324 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229587AbhBHH5w (ORCPT ); Mon, 8 Feb 2021 02:57:52 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by kvm5.telegraphics.com.au (Postfix) with ESMTP id 573232ABF5; Mon, 8 Feb 2021 02:57:10 -0500 (EST) Date: Mon, 8 Feb 2021 18:57:12 +1100 (AEDT) From: Finn Thain To: Xiaofei Tan cc: jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@openeuler.org Subject: Re: [PATCH for-next 00/32] spin lock usage optimization for SCSI drivers In-Reply-To: <1612697823-8073-1-git-send-email-tanxiaofei@huawei.com> Message-ID: <31cd807d-3d0-ed64-60d-fde32cb3833c@telegraphics.com.au> References: <1612697823-8073-1-git-send-email-tanxiaofei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 7 Feb 2021, Xiaofei Tan wrote: > Replace spin_lock_irqsave with spin_lock in hard IRQ of SCSI drivers. > There are no function changes, but may speed up if interrupt happen too > often. This change doesn't necessarily work on platforms that support nested interrupts. Were you able to measure any benefit from this change on some other platform? Please see also, https://lore.kernel.org/linux-scsi/89c5cb05cb844939ae684db0077f675f@h3c.com/