Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3865743pxb; Mon, 8 Feb 2021 02:01:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJyvNsZFKO3pieVBbp7uX25aH7YAIRkaFQwvxoqyuw5roXY42Gi91/vkRTph0b2A5Itx1ibA X-Received: by 2002:a17:906:b4a:: with SMTP id v10mr11893361ejg.382.1612778493062; Mon, 08 Feb 2021 02:01:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612778493; cv=none; d=google.com; s=arc-20160816; b=g91a+PpvrF0UU8u3zTx4/3QDOjouWZEob/PIjUrJ/rAw3/stculYC0/D4PLF+Z6r34 9M8oNeEoXMTYtUns700Om7Otywu2Gtze4E87IQ86sshx4OZzQoKUMJHBe6lQBWYc/cYA RMk33ogjb5o04cG5uxm+syPWwsQh+DOuvikwEJHLqj1Qqd+YOoxo4FzGVDlmysBcyZRY KJfxUoCmbyOVcouBfHTb1JNGT+F/8LBM/G4cFgiCur6OppV0qDTwcpGoEd1/88DWKxNL weD5XLbO5PJaoU+YapEE4G2kXntvfaoyijEtEBUopTolUa3ASKepsQvyMTzBsjsfENLS C86g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=3NhcpUvwMgEF2rRU4mx1o9wN8tYHo5OlqhAF8sWXq9M=; b=JqBGFDfunKE7sNVTH9ZaS+1S0thFqmDBsBnDG4zNcfhdOoNu+JFLbA0G7VOVTZI+72 zUxLDxuwZu5AepaC/gfphLxzHpX0stWOcUUAZ01MWYfzFk9rpWhHotwDpN7C6g0v962r Zy+777Jczne+X057vFHuvMlgwtfEHiAZhWxSWdFVqVVcl1oh9ml6hhsnc3a31U4y+x3U +I9/zdwaq5hga1AEj9uoVNJm9M9po05ok2yWt2kJILBZYMgj+Tz8P/xYFPOeocmVrb5t XjJ/gy4S9QoDYv65HJqBRBE44tsq+N1dzzao6xun3A6gqhTXRMSftGmU2EJIrNzDey2r iR7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=cumVrgka; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d4si10812477ejb.594.2021.02.08.02.01.08; Mon, 08 Feb 2021 02:01:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=cumVrgka; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232158AbhBHJ7r (ORCPT + 99 others); Mon, 8 Feb 2021 04:59:47 -0500 Received: from mx2.suse.de ([195.135.220.15]:34018 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232021AbhBHJte (ORCPT ); Mon, 8 Feb 2021 04:49:34 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1612777728; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3NhcpUvwMgEF2rRU4mx1o9wN8tYHo5OlqhAF8sWXq9M=; b=cumVrgkaunXuO6f9PY170PKriCorRoIVGi2zdDkYcDguu3RJ7sDt6XroUa4+2Bpkdhv2hs BieJgAhpprvHACzZ/tyu106MaAMLcLVdtFAhmKhkINjYZ1TqUQilo3ICF25vqpJR76GEHE u5I8/zp7ei0cTHCwYx+RXxe+5xOs1mY= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D20D2AC6E; Mon, 8 Feb 2021 09:48:48 +0000 (UTC) Subject: Re: [PATCH 7/7] xen/evtchn: read producer index only once To: Juergen Gross Cc: Boris Ostrovsky , Stefano Stabellini , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org References: <20210206104932.29064-1-jgross@suse.com> <20210206104932.29064-8-jgross@suse.com> From: Jan Beulich Message-ID: <72334160-cffe-2d8a-23b7-2ea9ab1d803a@suse.com> Date: Mon, 8 Feb 2021 10:48:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210206104932.29064-8-jgross@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06.02.2021 11:49, Juergen Gross wrote: > In evtchn_read() use READ_ONCE() for reading the producer index in > order to avoid the compiler generating multiple accesses. > > Signed-off-by: Juergen Gross > --- > drivers/xen/evtchn.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c > index 421382c73d88..f6b199b597bf 100644 > --- a/drivers/xen/evtchn.c > +++ b/drivers/xen/evtchn.c > @@ -211,7 +211,7 @@ static ssize_t evtchn_read(struct file *file, char __user *buf, > goto unlock_out; > > c = u->ring_cons; > - p = u->ring_prod; > + p = READ_ONCE(u->ring_prod); > if (c != p) > break; Why only here and not also in rc = wait_event_interruptible(u->evtchn_wait, u->ring_cons != u->ring_prod); or in evtchn_poll()? I understand it's not needed when ring_prod_lock is held, but that's not the case in the two afaics named places. Plus isn't the same then true for ring_cons and ring_cons_mutex, i.e. aren't the two named places plus evtchn_interrupt() also in need of READ_ONCE() for ring_cons? Jan