Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3868976pxb; Mon, 8 Feb 2021 02:06:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJz7aY+oZCuOWnCFKC0DkDFjmtMEPSsor/o5XNFZyX50uS6PBiET3BDmgLHHcgJOA+rgMELb X-Received: by 2002:a17:906:d93:: with SMTP id m19mr15931656eji.212.1612778784632; Mon, 08 Feb 2021 02:06:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612778784; cv=none; d=google.com; s=arc-20160816; b=n1D8GlqnZx5SNEQlx4EEF7XMbgOnv2qTTMKmon5mSPXP82aAJFmZpodXWNHNfFTpwH WJlWD3rkc76UTKelMouNhmUmpUlDtRZU94ZtpG/mhWpEW8os8Tx1LOH689P8lgqNLeL7 HctV8B6A6WB+hMxX/9vZ+iXKn9dDQhCpGp+hslwdJG2/w3rH9iRLbxAmhvvAhfSdTvmC PyQrLBxpjUklGTPUw24hQCe3fNeWS5c3G4ixdrDlf2yACDPob1fcMQXUv4eXADJ6saxT GWPUZYQ6D4rUePP3/tE2abq8FAjhjSACcSqQNqs1TZaCEZw/YEBoGACu/hHHdOS2IBXq wkWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=3gwIjwGJhFohxSRNfEvUv5IayIUrXak/LLs4dK3jjGY=; b=gMbPA/UjZDsYmnruDey8gYjOgLZQEra3XkwIqzrdunU8bjHk9k85A7+2Twy9NgXSfU ll/Z7cuXYSaDk6gRPG+4d2vejObkSkWp+9tc54gn3dyiQHC8fBGoDb5zly1RzywWQ58s 02wTQW8scB4C2VgLHzDrD7ZvgeE19udWYTE5GurfnKbex4zEVGgGRyJkasd9QuOyZW7g tULV+4Z+whmRwhlsJnS9NlMMbx0IR2UDGtiXXJ27X4wxHeP0gdgLSFuAAPnDlN08A0Y1 mohhp/ryrw1A/gxRp6tGQUs0bhVvHRv8mIxMaQeMB0lyTud4EWQs8qXlVfBoXVs0T/Y+ rjLA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o16si11216363eds.116.2021.02.08.02.06.01; Mon, 08 Feb 2021 02:06:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232220AbhBHKDM (ORCPT + 99 others); Mon, 8 Feb 2021 05:03:12 -0500 Received: from out30-57.freemail.mail.aliyun.com ([115.124.30.57]:52177 "EHLO out30-57.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232134AbhBHJxR (ORCPT ); Mon, 8 Feb 2021 04:53:17 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R821e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0UOBlCQ3_1612777945; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UOBlCQ3_1612777945) by smtp.aliyun-inc.com(127.0.0.1); Mon, 08 Feb 2021 17:52:34 +0800 From: Jiapeng Chong To: ulf.hansson@linaro.org Cc: lgirdwood@gmail.com, broonie@kernel.org, linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] mmc: omap-hsmmc: Simplify bool comparison Date: Mon, 8 Feb 2021 17:52:23 +0800 Message-Id: <1612777943-43609-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warning: ./drivers/mmc/host/omap_hsmmc.c:297:6-25: WARNING: Comparison of 0/1 to bool variable. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/mmc/host/omap_hsmmc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index aa9cc49..a59e9c3 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -285,22 +285,22 @@ static int omap_hsmmc_set_pbias(struct omap_hsmmc_host *host, bool power_on) return 0; if (power_on) { - if (host->pbias_enabled == 0) { + if (!host->pbias_enabled) { ret = regulator_enable(host->pbias); if (ret) { dev_err(host->dev, "pbias reg enable fail\n"); return ret; } - host->pbias_enabled = 1; + host->pbias_enabled = true; } } else { - if (host->pbias_enabled == 1) { + if (host->pbias_enabled) { ret = regulator_disable(host->pbias); if (ret) { dev_err(host->dev, "pbias reg disable fail\n"); return ret; } - host->pbias_enabled = 0; + host->pbias_enabled = false; } } -- 1.8.3.1