Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3904609pxb; Mon, 8 Feb 2021 03:10:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJxsC0eyBEZ7LTwbZDgKKDsFGSvqzKFZMcylPoaLE3vuEvR7yFUyamLqbEo93k+/Zx9rCUi9 X-Received: by 2002:aa7:dd4c:: with SMTP id o12mr16160020edw.180.1612782614131; Mon, 08 Feb 2021 03:10:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612782614; cv=none; d=google.com; s=arc-20160816; b=TdQLWh0FXUUsY6FNSEKKDJZDThDzcoW3xPlJWPFkfYzzPJJOsxDUY7JVlq9f7Zjd0y uNGAq3K/EHF1DByTdfPYwa9uDqGHpmm68g8v7iWsOAMoEk1ad8eExV5x2ROS+KGhgNGU F4g1etTq88pYyV/DAoFLFFLVnVUrxaX/82q/ERMM3KTUwGN6y72GVAUi9ajjpC4QJjuz Iz+h2ab04zb+ywhpuknuaTjriI5JtnXpnWJbUVu2z1ApYa3GRUTeMnqnQarcuKdi6bey OKzCdyMOUrofbbrHNJwmn9b8JTMUmySSjvIphHBkd1e0yQSsfPBM+kBPquhlTUTmYIqr XHpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:mime-version:user-agent:date :message-id:subject:from:references:cc:to:dkim-signature; bh=Y1k1Irf/aD43gtYCsWD5VZ8YG64iTvviIv/OIuLN4mo=; b=hGGWL2DPT2cgAQQRMPDL2fFMUbP7rguFGV9wbI05NQ617a8NB/l1F2S9cwC1S5POF3 99yw75zCY4Phed+ILb0+SVWpaWTR+fmZCKncQI58PWjItAmpZFQF/JP4aYkW4L+ik3rD U/rhp6CV1X6No1XQ5BD9hLUfPoQOUtCDST14egTHmUn+szsOFge9ClERtRb+1AxllKaO BYXV5DBM9CZiaU77pKSvb9XX/S/st+EO2ot7H/zW94ld6ve2yhJodeVg6AIaL6OKBRrW xygHutoCWzjNPOaCH8H1Q/Bbq9cnrP/Yqa2cJ644VukmEwZhyseMSZD1xzMi9y+sJk+0 TWsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=r8zjScQI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s7si8203464edw.598.2021.02.08.03.09.49; Mon, 08 Feb 2021 03:10:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=r8zjScQI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232957AbhBHLHb (ORCPT + 99 others); Mon, 8 Feb 2021 06:07:31 -0500 Received: from mx2.suse.de ([195.135.220.15]:58326 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232835AbhBHLAP (ORCPT ); Mon, 8 Feb 2021 06:00:15 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1612781968; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Y1k1Irf/aD43gtYCsWD5VZ8YG64iTvviIv/OIuLN4mo=; b=r8zjScQIHDKIuFx1t0KulyJX0azA91ELxLtXUTH0g20l/6Bz95Jj0Hu/TLY/UUQFZoAJ5C /tePjvH2o+wOS0ig5FAqfj+oDk12BNhw0oJXcellZ62rb+A9HEQ4RJKD3ynqWj3ZFFfMnG 8NjApdjvOsQ/Au88Ib9MFa5koRyNOYE= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D3377AE74; Mon, 8 Feb 2021 10:59:27 +0000 (UTC) To: Jan Beulich Cc: Boris Ostrovsky , Stefano Stabellini , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org References: <20210206104932.29064-1-jgross@suse.com> <20210206104932.29064-8-jgross@suse.com> <72334160-cffe-2d8a-23b7-2ea9ab1d803a@suse.com> <626f500a-494a-0141-7bf3-94fb86b47ed4@suse.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Subject: Re: [PATCH 7/7] xen/evtchn: read producer index only once Message-ID: Date: Mon, 8 Feb 2021 11:59:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="g10FMe3I19WjDHFRhrA8hHzwXJTqmeBhS" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --g10FMe3I19WjDHFRhrA8hHzwXJTqmeBhS Content-Type: multipart/mixed; boundary="WbA8Zux20nsOlI7TWqLh2MCi1HGxyzgG9"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Jan Beulich Cc: Boris Ostrovsky , Stefano Stabellini , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Message-ID: Subject: Re: [PATCH 7/7] xen/evtchn: read producer index only once References: <20210206104932.29064-1-jgross@suse.com> <20210206104932.29064-8-jgross@suse.com> <72334160-cffe-2d8a-23b7-2ea9ab1d803a@suse.com> <626f500a-494a-0141-7bf3-94fb86b47ed4@suse.com> In-Reply-To: --WbA8Zux20nsOlI7TWqLh2MCi1HGxyzgG9 Content-Type: multipart/mixed; boundary="------------1B0C26C8A87E3798CD3649FF" Content-Language: en-US This is a multi-part message in MIME format. --------------1B0C26C8A87E3798CD3649FF Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 08.02.21 11:51, Jan Beulich wrote: > On 08.02.2021 11:41, J=C3=BCrgen Gro=C3=9F wrote: >> On 08.02.21 10:48, Jan Beulich wrote: >>> On 06.02.2021 11:49, Juergen Gross wrote: >>>> In evtchn_read() use READ_ONCE() for reading the producer index in >>>> order to avoid the compiler generating multiple accesses. >>>> >>>> Signed-off-by: Juergen Gross >>>> --- >>>> drivers/xen/evtchn.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c >>>> index 421382c73d88..f6b199b597bf 100644 >>>> --- a/drivers/xen/evtchn.c >>>> +++ b/drivers/xen/evtchn.c >>>> @@ -211,7 +211,7 @@ static ssize_t evtchn_read(struct file *file, ch= ar __user *buf, >>>> goto unlock_out; >>>> =20 >>>> c =3D u->ring_cons; >>>> - p =3D u->ring_prod; >>>> + p =3D READ_ONCE(u->ring_prod); >>>> if (c !=3D p) >>>> break; >>> >>> Why only here and not also in >>> >>> rc =3D wait_event_interruptible(u->evtchn_wait, >>> u->ring_cons !=3D u->ring_prod); >>> >>> or in evtchn_poll()? I understand it's not needed when >>> ring_prod_lock is held, but that's not the case in the two >>> afaics named places. Plus isn't the same then true for >>> ring_cons and ring_cons_mutex, i.e. aren't the two named >>> places plus evtchn_interrupt() also in need of READ_ONCE() >>> for ring_cons? >> >> The problem solved here is the further processing using "p" multiple >> times. p must not be silently replaced with u->ring_prod by the >> compiler, so I probably should reword the commit message to say: >> >> ... in order to not allow the compiler to refetch p. >=20 > I still wouldn't understand the change (and the lack of > further changes) then: The first further use of p is > outside the loop, alongside one of c. IOW why would c > then not need treating the same as p? Its value wouldn't change, as ring_cons is being modified only at the bottom of this function, and nowhere else (apart from the reset case, but this can't run concurrently due to ring_cons_mutex). > I also still don't see the difference between latching a > value into a local variable vs a "freestanding" access - > neither are guaranteed to result in exactly one memory > access afaict. READ_ONCE() is using a pointer to volatile, so any refetching by the compiler would be a bug. > And of course there's also our beloved topic of access > tearing here: READ_ONCE() also excludes that (at least as > per its intentions aiui). Yes, but I don't see an urgent need to fix that, as there would be thousands of accesses in the kernel needing a fix. A compiler tearing a naturally aligned access into multiple memory accesses would be rejected as buggy from the kernel community IMO. Juergen --------------1B0C26C8A87E3798CD3649FF Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------1B0C26C8A87E3798CD3649FF-- --WbA8Zux20nsOlI7TWqLh2MCi1HGxyzgG9-- --g10FMe3I19WjDHFRhrA8hHzwXJTqmeBhS Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmAhGY8FAwAAAAAACgkQsN6d1ii/Ey/W rwf+KC8M1vX876+HEvj1ckqQSbTHVV50T/sybxL3l8haeurUmI5jCXfSElNw7p2yJ07YT8pZQF3f /LlODxDm38K7gF32W1tcMJoWhV11GS/l8+4apQOENKEpRecaa8KdlkgD9N67m5BFw9GUSXvaEL3v Th6gKvL4FqLn80QutvDR9XZx2NMKnexFM3akYUbaQJBBCwL65Ej2IZGoipoRZsmWFBItpEnnMzem pyprwsthM4ohdRJ0ClC1Sy/rxznmHl44pQJota7F4L7f6HpK2h9laxrYX2dx9dTsWKuDwwFw5V02 g1BHM+8Q/+qy8xs7G0Fd3lrZmpXI/3HN93G33+UfiA== =ecN0 -----END PGP SIGNATURE----- --g10FMe3I19WjDHFRhrA8hHzwXJTqmeBhS--