Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 8 Feb 2021 11:49:14 +0000
From:   Phillip Potter <phil@philpotter.co.uk>
To:     Alexander Sverdlin <alexander.sverdlin@nokia.com>
Cc:     devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        f.fainelli@gmail.com, andrew@lunn.ch, davem@davemloft.net,
        chris.packham@alliedtelesis.co.nz, gregkh@linuxfoundation.org
Subject: Re: [PATCH] staging: octeon: remove braces from single-line block
Message-ID: <20210208114914.GA115411@kernelvm>
References: <20210206201701.5273-1-phil@philpotter.co.uk>
 <51bab7d2-2f37-b4de-71b5-47cfe8857f02@nokia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <51bab7d2-2f37-b4de-71b5-47cfe8857f02@nokia.com>
Precedence: bulk

On Mon, Feb 08, 2021 at 08:14:02AM +0100, Alexander Sverdlin wrote:
> Hi!
> 
> On 06/02/2021 21:17, Phillip Potter wrote:
> > This removes the braces from the if statement that checks the
> > physical node return value in cvm_oct_phy_setup_device, as this
> > block contains only one statement. Fixes a style warning.
> > 
> > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> 
> Reviewed-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> 

Thank you Alexander.

> > ---
> >  drivers/staging/octeon/ethernet-mdio.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/octeon/ethernet-mdio.c b/drivers/staging/octeon/ethernet-mdio.c
> > index 0bf545849b11..b0fd083a5bf2 100644
> > --- a/drivers/staging/octeon/ethernet-mdio.c
> > +++ b/drivers/staging/octeon/ethernet-mdio.c
> > @@ -146,9 +146,8 @@ int cvm_oct_phy_setup_device(struct net_device *dev)
> >  		goto no_phy;
> >  
> >  	phy_node = of_parse_phandle(priv->of_node, "phy-handle", 0);
> > -	if (!phy_node && of_phy_is_fixed_link(priv->of_node)) {
> > +	if (!phy_node && of_phy_is_fixed_link(priv->of_node))
> >  		phy_node = of_node_get(priv->of_node);
> > -	}
> >  	if (!phy_node)
> >  		goto no_phy;
> >  
> 
> -- 
> Best regards,
> Alexander Sverdlin.

Regards,
Phil Potter