Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3945810pxb; Mon, 8 Feb 2021 04:18:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJzpCcysJbs0SHayrE+t6Q1BLCL0vGb4/D0U25PLMhrwLrJwz8jRSB5KE4sArlOKUIDhm958 X-Received: by 2002:a17:906:c0cd:: with SMTP id bn13mr16170578ejb.368.1612786692718; Mon, 08 Feb 2021 04:18:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612786692; cv=none; d=google.com; s=arc-20160816; b=Xo916wWKTTrFPPgRzW80c60rcn4Icd+XP343bld5/k9N/jC33j/uKXibGAwCy44P8d rG9sYf/nLDxpWIWmhbW3q3Pn9G5DXLT/iHdFC+Tv/HXM5KWUJOiI13XiSsPy0Wj0GHXz dLAw9rQBYIOVg6iPTMZpKO46lOWfP4mziDq1c8b+Su6fD+MS2VKsUg/Uwb0MAzRblIBJ a6fKPnRbNpClUSm9VPrr/TcNISasjV1VGsx4UteEHdTp5a7MlaabrgJFbihDzZp2ICFk QbKdYVBkyhKF6k+ih11RA5UtDW1Zg/cjIveOcCxNCu4j/JHguvvfv3381yH/c/GhpRtn 1uEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=HLQKhACcS3Wb7H2iooWNqoUh4cbB5X023FEHFCPsL4U=; b=Hs3meXe1zBOkD9pK4Rv8T8RgfneNHnC66GQp9QpAmF9TlNQL8qSkxyzNcm3rV7m8K4 UgRmDzHesieTYU3ikyWiug6tl1W4CSCVq5MCk89gVBUEYxldRObrYuIXMXWrkVgNU836 8psu/Fq8ogfk2AG+C1x99a/qNBHwfR0Em6zpsWTT13o1RJ9WXdjCn24NnYxTdTUZlP1a XpnHMekWdgBnQrg9/oFLTJmRSTzJyHrk2Cbn3siKTNWLZfWE1/sP0pU2TtyBRTelWRKa vJ/kQrNZMqxdLeIXd4jM3MRbKclyjLopdXQTmitgtAqGq1smN05qEldSeJ49Zq+QOk2l Q4RQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kIbb+I40; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r8si11084501ejc.517.2021.02.08.04.17.49; Mon, 08 Feb 2021 04:18:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kIbb+I40; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229821AbhBHMQx (ORCPT + 99 others); Mon, 8 Feb 2021 07:16:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:40420 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233445AbhBHL55 (ORCPT ); Mon, 8 Feb 2021 06:57:57 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7998064E6E; Mon, 8 Feb 2021 11:57:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1612785430; bh=UjSCVRlYlYz5lJ+/E0HItPpS4FLAKsZx0Wymr8k4yKg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kIbb+I40rvFB55fGxIaXy3dbufJPL7HvcyTfsLxGSqKTns8yKOg6qeUEGqHbQbrK8 l6QH9Oj0PFRYMhIfIj3QETw/ca49Lk8iiD5GzHn5Wu0F0RpD4hhI2/CKI8MmNnr+xZ YrRl6YwidC94NQSe3TZhVPHpslVJIB1XdhuVfc4c= Date: Mon, 8 Feb 2021 12:57:07 +0100 From: Greg Kroah-Hartman To: taehyun cho Cc: balbi@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: dwc3: make USB_DWC3_EXYNOS independent Message-ID: References: <20210208114538.134766-1-taehyun.cho@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210208114538.134766-1-taehyun.cho@samsung.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 08, 2021 at 08:45:38PM +0900, taehyun cho wrote: > 'ARCH_EXYNOS' is no more used. I do not understand this sentance. I see it used in many places in the kernel tree still, is it being removed? And if so, as of what commit is this true? > 'USB_DWC3_EXYNOS' is glue layer > which can be used with Synopsys DWC3 controller on Exynos SoCs. > 'USB_DWC3_EXYNOS' can be used from Exynos5 to Exynos9. This is fine, but the help text doesn't show this, why not put that information there? > > Signed-off-by: taehyun cho > --- > drivers/usb/dwc3/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig > index 2133acf8ee69..dc2f92ac8ef6 100644 > --- a/drivers/usb/dwc3/Kconfig > +++ b/drivers/usb/dwc3/Kconfig > @@ -67,10 +67,10 @@ config USB_DWC3_OMAP > > config USB_DWC3_EXYNOS > tristate "Samsung Exynos Platform" > - depends on (ARCH_EXYNOS || COMPILE_TEST) && OF > + depends on (USB_DWC3 || COMPILE_TEST) && OF > default USB_DWC3 > help > - Recent Exynos5 SoCs ship with one DesignWare Core USB3 IP inside, > + Exynos SoCs chip with one DesignWare Core USB3 IP inside, This does not make much sense anymore, can you reword it? thanks, greg k-h