Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 8 Feb 2021 17:36:09 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Cezary Rojewski <cezary.rojewski@intel.com>
Cc:     dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
        dan.j.williams@intel.com, andriy.shevchenko@linux.intel.com,
        vireshk@kernel.org
Subject: Re: [PATCH v2] Revert "dmaengine: dw: Enable runtime PM"
Message-ID: <20210208120609.GC879029@vkoul-mobl.Dlink>
References: <20210203191924.15706-1-cezary.rojewski@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210203191924.15706-1-cezary.rojewski@intel.com>
Precedence: bulk

On 03-02-21, 20:19, Cezary Rojewski wrote:
> This reverts commit 842067940a3e3fc008a60fee388e000219b32632.
> For some solutions e.g. sound/soc/intel/catpt, DW DMA is part of a
> compound device (in that very example, domains: ADSP, SSP0, SSP1, DMA0
> and DMA1 are part of a single entity) rather than being a standalone
> one. Driver for said device may enlist DMA to transfer data during
> suspend or resume sequences.
> 
> Manipulating RPM explicitly in dw's DMA request and release channel
> functions causes suspend() to also invoke resume() for the exact same
> device. Similar situation occurs for resume() sequence. Effectively
> renders device dysfunctional after first suspend() attempt. Revert the
> change to address the problem.

Reverts also need proper tagging, so pls ensure that is done. I have
added the subsystem and driver tags and applied

-- 
~Vinod