Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3955877pxb; Mon, 8 Feb 2021 04:35:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJwuaJONtqyin1aNCAiGfWGo89XOyqxP13w1JlA++jdyoqLngLRMCHwYvCMmt3TLdplO5W+Y X-Received: by 2002:a50:e442:: with SMTP id e2mr17841337edm.235.1612787732134; Mon, 08 Feb 2021 04:35:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612787732; cv=none; d=google.com; s=arc-20160816; b=bNuptqutkaKISAUrzKY601AaIwqSKQe3nzx1fIjv7ZWCOXx+NwXaafReqoCp7HarNQ E5jh4baekvjSWF52nj4v89rWEQlD7vKQ4HIT1MVxqbi6XzAnh4vgA8UIE8mDqrQrnDHZ XjNO23P3FuJSwEX9hhSSkdvOg6Tu9h4EYu45I33c1gJpVMLn+uEeXwJuHehdo/H48qma /GFXbhXRdYVtaRX/GNpphLGhkAbl6sk+yS80lEG42z7NPFAtemds00ZCIXxixzwe8wXI AekEmyLsT/eSITqJYd/2zX1eVdPNzN1HEv4ZK1+VY8NAdg/WDkt5wWcEy/jLgjellglu wdFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=ogG0amaC4aGq2teJzSPyFux94rNCIQMroZhisTlgUA8=; b=eeILgAlTm/EWgWrZeHXSHA7+JJsvwIrEa+SOUrdhJ9UuchD+WphPcBXhwymM08j6lI FfrMf/r7SehoAAnv9bdpQFJRtNCTM0EQdO5Ip9V4epeSfMJRHCbkwI/8bo6URtiageat sjxTXq6n8h5e2VdJLCdX89i0Vnb4FHsZ0cGLVOSoKxHkER//DTqeB3Oo0TcAk3CaOJTZ v/AmTEr4ychDIYFFKNiS15pcwpfLSYVwbXDVu0DfBsTuWXlIntpa9CKqgX7hXGgvh8M6 AYtiH/VtBlA1clMUyDERgnxuxoYC7L3iH2yfhc8PX5lwYYqwejSQ5rCt5v1BisWbbr+/ tO9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siol.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i1si1520652edn.588.2021.02.08.04.35.07; Mon, 08 Feb 2021 04:35:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siol.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232002AbhBHMcx (ORCPT + 99 others); Mon, 8 Feb 2021 07:32:53 -0500 Received: from mailoutvs14.siol.net ([185.57.226.205]:52875 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231184AbhBHMTl (ORCPT ); Mon, 8 Feb 2021 07:19:41 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Zimbra) with ESMTP id AA79552249D; Mon, 8 Feb 2021 13:18:00 +0100 (CET) X-Virus-Scanned: amavisd-new at psrvmta12.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta12.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id qXiWpf59z7ur; Mon, 8 Feb 2021 13:18:00 +0100 (CET) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Zimbra) with ESMTPS id 541CA522360; Mon, 8 Feb 2021 13:18:00 +0100 (CET) Received: from kista.localdomain (cpe-86-58-58-53.static.triera.net [86.58.58.53]) (Authenticated sender: 031275009) by mail.siol.net (Zimbra) with ESMTPSA id 95FAF52234E; Mon, 8 Feb 2021 13:17:59 +0100 (CET) From: Jernej Skrabec To: mripard@kernel.org, wens@csie.org Cc: mturquette@baylibre.com, sboyd@kernel.org, airlied@linux.ie, daniel@ffwll.ch, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sunxi@googlegroups.com Subject: [PATCH v2 0/5] sunxi: fix H6 HDMI related issues Date: Mon, 8 Feb 2021 13:17:47 +0100 Message-Id: <20210208121752.2255465-1-jernej.skrabec@siol.net> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Over the year I got plenty of reports of troubles with H6 HDMI signal. Sometimes monitor flickers, sometimes there was no image at all and sometimes it didn't play well with AVR. It turns out there are multiple issues. Patch 1 fixes clock issue, which didn't adjust parent rate, even if it is allowed to do so. Patch 2 adds polarity config in tcon1. This is seemingly not needed for pre-HDMI2 controllers, although BSP drivers set it accordingly every time. It turns out that HDMI2 controllers often don't work with monitors if polarity is not set correctly. Patch 3 always set clock rate for HDMI controller. Patch 4 fixes H6 HDMI PHY setting. Patch 5 fixes comment and clock rate limit (wrong reasoning). Please take a look. Best regards, Jernej Changes from v1: - collected Chen-Yu tags (except on replaced patch 4) - Added some comments in patch 2 - Replaced patch 4 (see commit log for explanation) Jernej Skrabec (5): clk: sunxi-ng: mp: fix parent rate change flag check drm/sun4i: tcon: set sync polarity for tcon1 channel drm/sun4i: dw-hdmi: always set clock rate drm/sun4i: Fix H6 HDMI PHY configuration drm/sun4i: dw-hdmi: Fix max. frequency for H6 drivers/clk/sunxi-ng/ccu_mp.c | 2 +- drivers/gpu/drm/sun4i/sun4i_tcon.c | 25 +++++++++++++++++++++++++ drivers/gpu/drm/sun4i/sun4i_tcon.h | 6 ++++++ drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 10 +++------- drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h | 1 - drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c | 26 +++++++++----------------- 6 files changed, 44 insertions(+), 26 deletions(-) -- 2.30.0