Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp4022079pxb; Mon, 8 Feb 2021 06:13:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJy9H+vgtqp7L3RoBiVQy7RS1u6VhCuBKyTJe4USqu6EbZVBQGhoBWtC7hhNGT9gLLkOWP89 X-Received: by 2002:a50:9d0b:: with SMTP id v11mr17730334ede.308.1612793623537; Mon, 08 Feb 2021 06:13:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612793623; cv=none; d=google.com; s=arc-20160816; b=T0MGMd78+VEbMHWmBhRgrsTs+++8WB8abqptUcsZ6U3JQ52/gbI3DQAW9RndG1udws kKodzSXTzqWh8dmPl/jUIozF97xMlhZ0u4NMMcatOuaQ5nu4w1DAbgtR6/gnaNoEy+Wg zCScMO3g01NOOiK8x1QMzVe41wrf+sZKOTSvbtx5JFWSOprgyU9POeyOruiL5zct9L0W CTKQSduyVFFAFkJgv7K+E9vqXL8M8BQ2REctIQShKOrPDHJyLfrp4WpaDilUqCSr7SfW H7X7/dy99GGBu5U3/RDstjuF9ydFhRadCos7vIKRdxGrN0khQAP2aftwVGvjOHmD85vE HZeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=1xpWyEcqvAZ155a+rYHP+F0yV4FnKPMEdp0JUMca9rM=; b=iLBc6TuO71aNqS4YdQV9CLGdWeWD6XvZsrGBEp0FHKRKY/Amq/jQv0k30MFbpu8vPJ CdMtfDpIE2WHAW28GNe50+vthprC9IMHPovsVB/zS/BlQcUj++vFqE61plDoL+WUEvSR uv/C7ai+aVaVsLxVm8fc2gW0BDuaa9SHb/SsGxSSiONiaVn45EJ2QDmgJyarpaSfkhla kQjTmrZPRkcgGZjdUAtsnMVEIMoArsxFTvYbq3x8XEctF4rRJrgcyFBVimdENsy5s10r DdZKlo9OXUzQETSIwxnGVBEsW1layPiz8l4NPLZHv109QfNJqtFZBRaQ/twv4q2SN+cN 9dlw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a4si6004627eds.33.2021.02.08.06.13.19; Mon, 08 Feb 2021 06:13:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232113AbhBHOKL (ORCPT + 99 others); Mon, 8 Feb 2021 09:10:11 -0500 Received: from mail.baikalelectronics.com ([87.245.175.226]:57076 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231894AbhBHN5r (ORCPT ); Mon, 8 Feb 2021 08:57:47 -0500 From: Serge Semin To: Rob Herring , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Jakub Kicinski , Johan Hovold , Maxime Ripard , Joao Pinto , Lars Persson , Maxime Coquelin CC: Serge Semin , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Vyacheslav Mitrofanov , , , , , Subject: [PATCH v2 11/24] net: stmmac: dwmac-stm32: Cleanup STMMAC DT-config in remove cb Date: Mon, 8 Feb 2021 16:55:55 +0300 Message-ID: <20210208135609.7685-12-Sergey.Semin@baikalelectronics.ru> In-Reply-To: <20210208135609.7685-1-Sergey.Semin@baikalelectronics.ru> References: <20210208135609.7685-1-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The stmmac_remove_config_dt() method needs to be called on the device remove procedure otherwise for at least some of device-nodes will be left requested. Fixes: d2ed0a7755fe ("net: ethernet: stmmac: fix of-node and fixed-link-phydev leaks") Signed-off-by: Serge Semin --- drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c index 5d4df4c5254e..b45aab38c7b0 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c @@ -426,6 +426,8 @@ static int stm32_dwmac_remove(struct platform_device *pdev) stm32_dwmac_clk_disable(priv->plat->bsp_priv); + stmmac_remove_config_dt(pdev, priv->plat); + if (dwmac->irq_pwr_wakeup >= 0) { dev_pm_clear_wake_irq(&pdev->dev); device_init_wakeup(&pdev->dev, false); -- 2.29.2