Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp4034048pxb; Mon, 8 Feb 2021 06:29:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJyJWYYPE6Q6NXIVVAAmXF8gpWXDtgQmZgu9u95RoDxj4KK5i70A0xB47ITvYH55isXejVof X-Received: by 2002:a05:6402:1153:: with SMTP id g19mr12745212edw.292.1612794540772; Mon, 08 Feb 2021 06:29:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612794540; cv=none; d=google.com; s=arc-20160816; b=MPsfmWsc0JPADz10/SRgt18hYrHLPc8LSpltQzx3h6RnuXPcMnJIy4MCsNsAyO7cM5 CHFQfjD3goTKzovYg3knW8ga9vPGxVRG5cBG7jLOJs2eLuDJTR2+Ex4gYuVIEMGn+jcM 7AaEBmwenfFRomM0QXAbwiK7KsOxn+pwyP/dYGa2UK+jaoChhIi5XPzWDgmQpBoOHyks 6dHz35jLACQrU2rTetnoN5VTbVrKUjD2cAeqOZjWa6UiPHniMmOOi3jaX1aHOq88M5Zq P8Qp1WEX0rl6ye49ENJpXDh/1Xj2vKV5XGwKFP4l+4Tyeas4EKqN5SOCpeIofp0VQZMS LCUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=/dPfL2+EhlfroldCVOd2RFqnpT8wz2CO0QglLpg0jGg=; b=ay7k9GxrpKHL4o7J+VKMIGaaGA5r1n3Y8AcMLytuUNFh+/f1/gA1D2Yn9W62arFaOC QRzaRHwrBqbgtmkHlP11M0SY6zopYJ9ik3Yz+WClUFWWoXD/utt9kkBVn4Ue7YJAwOq+ wZJ8e2BNRqutJqkfIiYWzC4XA17SyKlrEmmQArc7xyIJb/CyM9O57uapkeVPy2+gi77E lTGAQelrC0rX1YuwA/66H+d3E4bfjzM0cIOk1sJ9YpSBOMaFBkOVEX6Tp9t7UR/+zk8M LY2tqf6gS1zjuCQlENcqzFpcHYkNw3XHs1KQZ0xwMezXL1LjeBix8BX9gZteXd6STu4v SAig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k8si11379879edn.92.2021.02.08.06.28.36; Mon, 08 Feb 2021 06:29:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233072AbhBHO1o (ORCPT + 99 others); Mon, 8 Feb 2021 09:27:44 -0500 Received: from mail.baikalelectronics.com ([87.245.175.226]:57512 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231426AbhBHOHR (ORCPT ); Mon, 8 Feb 2021 09:07:17 -0500 From: Serge Semin To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Jakub Kicinski , Joao Pinto , Jose Abreu , Maxime Coquelin CC: Serge Semin , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Vyacheslav Mitrofanov , Russell King , Andrew Lunn , Heiner Kallweit , , , , Subject: [PATCH 11/20] net: stmmac: Discard index usage in the dirty_rx init Date: Mon, 8 Feb 2021 17:03:32 +0300 Message-ID: <20210208140341.9271-12-Sergey.Semin@baikalelectronics.ru> In-Reply-To: <20210208140341.9271-1-Sergey.Semin@baikalelectronics.ru> References: <20210208140341.9271-1-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Indeed in accordance with the initialization loop logics the statement "(i - priv->dma_rx_size)" will always equal to zero. Just initialize the dirty_rx pointer with zero then. Signed-off-by: Serge Semin --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 8599ef6df52f..abe8db9965f4 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -1412,7 +1412,7 @@ static int init_dma_rx_desc_rings(struct net_device *dev, gfp_t flags) } rx_q->cur_rx = 0; - rx_q->dirty_rx = (unsigned int)(i - priv->dma_rx_size); + rx_q->dirty_rx = 0; /* Setup the chained descriptor addresses */ if (priv->mode == STMMAC_CHAIN_MODE) { -- 2.29.2