Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Ioana Ciornei <ioana.ciornei@nxp.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
CC:     Stuart Yoder <stuyoder@gmail.com>,
        Laurentiu Tudor <laurentiu.tudor@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] bus: fsl-mc: Fix test for end of loop
Thread-Topic: [PATCH] bus: fsl-mc: Fix test for end of loop
Thread-Index: AQHW+JXWIedFA+IGmEmzK+UDvJ/0YKpOWUCA
Date:   Mon, 8 Feb 2021 14:18:04 +0000
Message-ID: <20210208141803.bqbnbgvprtlo3vs6@skbuf>
References: <YBf0Br9obNGZTcNI@mwanda>
In-Reply-To: <YBf0Br9obNGZTcNI@mwanda>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <E6F8F4BC3EF4A442A8258E31E89D3F44@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a5786758-0695-47ee-dad5-08d8cc3c599e
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2021 14:18:04.5272
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: u8X3QC98TUCezuGimtTR3HZN+2hUogZja9wR0RwNfGtytEvdJU7tAaBuoIfqT6Nfjb92hd+ZjLxj54Fiy2PMcg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3741
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 01, 2021 at 03:28:54PM +0300, Dan Carpenter wrote:
> The "desc" pointer can't possibly be NULL here.  If we can't find the
> correct "desc" then tt points to the last element of the
> fsl_mc_accepted_cmds[] array.  Fix this by testing if
> "i =3D=3D FSL_MC_NUM_ACCEPTED_CMDS" instead.
>=20
> Fixes: 2cf1e703f066 ("bus: fsl-mc: add fsl-mc userspace support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Hi,

I just noticed that Greg wasn't copied on the initial email.

If you don't mind I will re-submit your patch along with other updates
to the fsl-mc bus so that you don't have to bother.

Ioana

> ---
>  drivers/bus/fsl-mc/fsl-mc-uapi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/bus/fsl-mc/fsl-mc-uapi.c b/drivers/bus/fsl-mc/fsl-mc=
-uapi.c
> index eeb988c9f4bb..bdcd9d983a78 100644
> --- a/drivers/bus/fsl-mc/fsl-mc-uapi.c
> +++ b/drivers/bus/fsl-mc/fsl-mc-uapi.c
> @@ -338,7 +338,7 @@ static int fsl_mc_command_check(struct fsl_mc_device =
*mc_dev,
>  		if ((cmdid & desc->cmdid_mask) =3D=3D desc->cmdid_value)
>  			break;
>  	}
> -	if (!desc) {
> +	if (i =3D=3D FSL_MC_NUM_ACCEPTED_CMDS) {
>  		dev_err(&mc_dev->dev, "MC command 0x%04x: cmdid not accepted\n", cmdid=
);
>  		return -EACCES;
>  	}
> --=20
> 2.29.2
> =