Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 8 Feb 2021 16:25:35 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     Alexey Dobriyan <adobriyan@gmail.com>
Cc:     mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] sched: make struct task_struct::state 32-bit
Message-ID: <YCFX7zuwp0haWZFl@hirez.programming.kicks-ass.net>
References: <20210206151832.GA487103@localhost.localdomain>
 <YCETqt8Vqb8R6qmA@hirez.programming.kicks-ass.net>
 <20210208143025.GA10066@localhost.localdomain>
 <20210208145245.GA11701@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210208145245.GA11701@localhost.localdomain>
Precedence: bulk

On Mon, Feb 08, 2021 at 05:52:45PM +0300, Alexey Dobriyan wrote:
> On Mon, Feb 08, 2021 at 05:30:25PM +0300, Alexey Dobriyan wrote:
> > On Mon, Feb 08, 2021 at 11:34:18AM +0100, Peter Zijlstra wrote:
> > > On Sat, Feb 06, 2021 at 06:18:32PM +0300, Alexey Dobriyan wrote:
> > > 
> > > > Silently delete "extern" from prototypes.
> > > 
> > > NAK, extern is right.
> > 
> > Extern is only necessary for variables.
> 
> Specifically C17, 6.2.2 p5 (linkage of identifiers):
> 
> 	if the declaration of an identifier for a function has no
> 	storage-class specifier, its linkage is determined exactly as if
> 	it were declared with the storage-class specifier "extern".
> 
> This is why nothing happens if "extern" is deleted.

I know, but I still very much like extern on the function declarations
too. It tells me the definition isn't to be found in this TU.