Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp4235946pxb; Mon, 8 Feb 2021 11:05:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJwqZ42OxtejSAEzLkEmcjDpF7DuP+9+p5r7TgFL6MoCEcE8sKXb9SpvhutcbI7gJEbyVtkG X-Received: by 2002:a17:907:75c6:: with SMTP id jl6mr17763152ejc.243.1612811148746; Mon, 08 Feb 2021 11:05:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612811148; cv=none; d=google.com; s=arc-20160816; b=OhI8JWpfY5i0A3VJAJ/ZAs1N0sKirJoxj/ljSxQhI61mLDX+x5Yc7XGpBrNPsMqwl3 HuscNjn92B1CN1oTyYUxsE7kHaqtJkg5+u5h3D8QZFPPDVQ2cmSQU0ITYneYojQhys0l uXDsnRucHCVTSxgETITRiRockkYWOnc636rB0jzEYLxmw8s2eYodJwM8BQFo1FgSmoVq FUQInPwWFrd7WcUMQ7jrLU3NLly7AkOyy91VL8zinXZA1CIk7ezo9D/vHQ5U1lYtRpBI v9b06XbO/rQbrnMMn7nS5xlbRy56T7+FCkOgC4I690EGpg1wiEDcRNOZToeCHkyKYaiz CtPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ke1hxt0FRH7sV6bLaq9pHrT4cON6Sd9F2qPDMzZG7NI=; b=ty3AgDBBY1oFel6Oa7Q7fIq3a1ufIwaxFO4YDcbS5wrOeNbtqAkzSGBWnsRvjAf224 bnAXSRx+MV21e6Xa4DRL5wfl0bxXbmTcTM+oVOjgImMbp+U3patPRshqIzjGrponRkjV BYptC6g7R5PDRyouAfaNOxkzoBN0Umz6iaY9sfm354XWaMcKQLTBL6k4CfFd4ICVKLP7 7JJnxIP/FtuZsCTS8m7ze1BUDPKFzPQI7BiZg5yr+D5k3bmchGI/VqW160yQklo+mNOC dogiBE0hL61xVpwHfhdPgAoY9YvEyIOhYEDEylmxYc27JF+PUdk3KDGwzrxSXQ4I8Gzv erKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=TwoTO4rv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b4si9804380edn.586.2021.02.08.11.05.24; Mon, 08 Feb 2021 11:05:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=TwoTO4rv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236056AbhBHTCt (ORCPT + 99 others); Mon, 8 Feb 2021 14:02:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234251AbhBHR1f (ORCPT ); Mon, 8 Feb 2021 12:27:35 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7324EC061793 for ; Mon, 8 Feb 2021 09:26:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ke1hxt0FRH7sV6bLaq9pHrT4cON6Sd9F2qPDMzZG7NI=; b=TwoTO4rvqglLPbU0a10zOrdEFi ETZHslKkqFVfe/ub6DERrZhVSXQQh0/TbAdhIjrUF/mwALGrnZCf0hkvVlcalQFFIQElif+GGRpqX mE1nkjHKru1zEOmwK7WjkklN/hk6GJtCCB8E476lhyHyH+kksvtD7DpNdpBRDfOZgF2YnUCPJ/t26 G7E39ADHWpHDC+1dXa2/ikcvBUwF+fEBUgtDyJrAOntZ5tv9tELDhT7EbZ7/wUIi1Wko7ldTppHn0 3AFPXoh3ss+QGtJmHOQfF7HaDi9RBnUnluR/Qb2WwwvVgeEnvbNsS12Od0FnayqCnc+bUGJc5Kwgs 3Veb73wA==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l9AIS-006HH7-U4; Mon, 08 Feb 2021 17:26:01 +0000 Date: Mon, 8 Feb 2021 17:26:00 +0000 From: Matthew Wilcox To: Yafang Shao Cc: andriy.shevchenko@linux.intel.com, david@redhat.com, vbabka@suse.cz, cl@linux.com, linmiaohe@huawei.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, pmladek@suse.com, rostedt@goodmis.org, sergey.senozhatsky@gmail.com, joe@perches.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/3] mm, slub: don't combine pr_err with INFO Message-ID: <20210208172600.GU308988@casper.infradead.org> References: <20210208101439.55474-1-laoar.shao@gmail.com> <20210208101439.55474-3-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210208101439.55474-3-laoar.shao@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 08, 2021 at 06:14:38PM +0800, Yafang Shao wrote: > It is strange to combine "pr_err" with "INFO", so let's remove the > prefix completely. So is this the right thing to do? Should it be pr_info() instead? Many of these messages do not appear to be error messages, but rather informational messages.