Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp4248183pxb; Mon, 8 Feb 2021 11:24:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJzoE57wKzH68UsTbVfy7/g8TsrjQj9WXrfu9DeMx3GNoH34rhbIK6tC/Y/vQD6XSAJrpmvv X-Received: by 2002:a50:da8b:: with SMTP id q11mr19063383edj.352.1612812297555; Mon, 08 Feb 2021 11:24:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612812297; cv=none; d=google.com; s=arc-20160816; b=MkSa6WcrbxKmHu7M5HcoBGzPcsuWB4SmAx+IKcpO+TCqrPzYKzHVy2hoWY8MxrmWvC qQ5gRU1pz5ZBQu7wifGm8r9FEyLeYT4k90JAJHVs3sHMgGydPhSUlEuu4X6kTgAATKhC po+oM/oaW0LMEWY4YxIX+hzPAu6EVnzu6ntCYDshwbqGKH7rYS6jR20MLnyqCjKfLTBQ 1CkABot5H0Or9v5OFjTgGqOp2ryesM1QtsHPbaogLJu27pJHNb453aPZsO7HQuIdfk+P E3dPkP/UdXYGkmno++xVMoFSxZKdLHRKDxz0uXLPAin5HB0G5BgB9o5Qw6QQz0J1+7S5 HBDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=G3vggCnwv1a5x1tFVgWimOFqJpf8AXpfQE3NRSp4gUw=; b=U2QyqFByhFUXjirEkRUbHH0wXjQjBn3i4rO8I5NwCtQa2UNmQweipIbvBq110p5bau h4mSJ3qIX8aShHFuPhokXZxzRXCSZOw73pLZRImLPzxspzcu3wvymXZVcWgIEstmc3Fb gBxB09/1Mz9tMs23rWC78waJuauPHVeCayzK+d7o0HGhdF8oxA+7Y9ZWCgvt+V4VPxqX TtNTUt5z3u9deyJRIau0r6KobTOuor5OjrtAHV/PXPqAeuIQ7WimmcPujgnF49TiKh9v pViis4Sa4UplNRne33RA9XyfP9ZmvQUwvUNPDas3BXsXfk3sK0V+2KdFHhP1KkhYf7KC vATQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iigNBqwe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id fx15si11458709ejb.27.2021.02.08.11.24.33; Mon, 08 Feb 2021 11:24:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iigNBqwe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233001AbhBHTXW (ORCPT + 99 others); Mon, 8 Feb 2021 14:23:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:47380 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235163AbhBHSAp (ORCPT ); Mon, 8 Feb 2021 13:00:45 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 94C9964EC7; Mon, 8 Feb 2021 17:58:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612807118; bh=QG+IXIvC27Sf/5lk1f9hJH/eFsjq66BiJ8/ljnlbw+s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iigNBqweQ2kDBpGMvj7p4mzcuwZrrTYo6YQT9nDGHF31jh1b/f6DL3qlCuKutpfU7 Ll6/ltJrtCH5lGndE4UG9NFJe0WmSOSqPwqAEl3q7r9TMPReBh159L5RQvh7gywz6o Sjd73wiZBNzwCP4OJ9LMrEKOvHQcGkpUrYZBaW37hK9KEt0+YMBwyAM3wv7zms1XoO FN2EnpzbJ/4o3KKsh20BsGy++4pVzeRlxaj5Po1vkWW+nH78nEfyuZwqfTvL3dNayo RD5GVgCzW1vacpwQITnI6adfrkQOWZ6NpRyeqbCDtqJ4oiI+qh9pmRn/2dfm7qv9fG kIAw54A35Al8g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Victor Lu , Nicholas Kazlauskas , Anson Jacob , Daniel Wheeler , Alex Deucher , Sasha Levin , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.10 23/36] drm/amd/display: Fix dc_sink kref count in emulated_link_detect Date: Mon, 8 Feb 2021 12:57:53 -0500 Message-Id: <20210208175806.2091668-23-sashal@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210208175806.2091668-1-sashal@kernel.org> References: <20210208175806.2091668-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Victor Lu [ Upstream commit 3ddc818d9bb877c64f5c649beab97af86c403702 ] [why] prev_sink is not used anywhere else in the function and the reference to it from dc_link is replaced with a new dc_sink. [how] Change dc_sink_retain(prev_sink) to dc_sink_release(prev_sink). Signed-off-by: Victor Lu Reviewed-by: Nicholas Kazlauskas Acked-by: Anson Jacob Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 0f7749e9424d4..f1fea71a7073c 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -1792,8 +1792,8 @@ static void emulated_link_detect(struct dc_link *link) link->type = dc_connection_none; prev_sink = link->local_sink; - if (prev_sink != NULL) - dc_sink_retain(prev_sink); + if (prev_sink) + dc_sink_release(prev_sink); switch (link->connector_signal) { case SIGNAL_TYPE_HDMI_TYPE_A: { -- 2.27.0