Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 8 Feb 2021 21:58:10 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Ioana Ciornei <ciorneiioana@gmail.com>
Cc:     gregkh@linuxfoundation.org, laurentiu.tudor@nxp.com,
        linux-kernel@vger.kernel.org, Ioana Ciornei <ioana.ciornei@nxp.com>
Subject: Re: [PATCH 1/3] bus: fsl-mc: Fix test for end of loop
Message-ID: <20210208185810.GM20820@kadam>
References: <20210208170949.3070898-1-ciorneiioana@gmail.com>
 <20210208170949.3070898-2-ciorneiioana@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210208170949.3070898-2-ciorneiioana@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Mon, Feb 08, 2021 at 07:09:47PM +0200, Ioana Ciornei wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
> 
> The "desc" pointer can't possibly be NULL here.  If we can't find the
> correct "desc" then tt points to the last element of the
> fsl_mc_accepted_cmds[] array.  Fix this by testing if
> "i == FSL_MC_NUM_ACCEPTED_CMDS" instead.
> 
> Fixes: 2cf1e703f066 ("bus: fsl-mc: add fsl-mc userspace support")
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Generally the tags are expected to go in chronological order:

Fixes: commit
Signed-off-by: Author
Acked-by: Whoever
Signed-off-by: Maintainer

regards,
dan carpenter