Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: PA1J/V2TjN9umTntqm0Xxcp9fk6mnnDlw+4XmRyUotg/3T33tgq91aWcavdZxwgpWKCXmzKCou
 AonBsatv0q6g==
IronPort-SDR: QFiE6hhQ7xqTdMWFzftnB/WnnPXpSOfw5ZYyI/Z7AKEUaPm8ftugDgT834NB23DeXZQZR8wN4v
 oYVe7pKiTvBQ==
Date:   Mon, 8 Feb 2021 11:10:18 -0800
From:   "Luck, Tony" <tony.luck@intel.com>
To:     "Liang, Kan" <kan.liang@linux.intel.com>
Cc:     Borislav Petkov <bp@alien8.de>, peterz@infradead.org,
        acme@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org,
        tglx@linutronix.de, namhyung@kernel.org, jolsa@redhat.com,
        ak@linux.intel.com, yao.jin@linux.intel.com,
        alexander.shishkin@linux.intel.com, adrian.hunter@intel.com,
        Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@intel.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        "Ravi V. Shankar" <ravi.v.shankar@intel.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Len Brown <len.brown@intel.com>
Subject: Re: [PATCH 02/49] x86/cpu: Describe hybrid CPUs in cpuinfo_x86
Message-ID: <20210208191018.GA86425@agluck-desk2.amr.corp.intel.com>
References: <1612797946-18784-1-git-send-email-kan.liang@linux.intel.com>
 <1612797946-18784-3-git-send-email-kan.liang@linux.intel.com>
 <20210208175640.GD18227@zn.tnic>
 <cddc013c-5b48-f792-058c-009e43cfe547@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cddc013c-5b48-f792-058c-009e43cfe547@linux.intel.com>
Precedence: bulk

On Mon, Feb 08, 2021 at 02:04:24PM -0500, Liang, Kan wrote:
> On 2/8/2021 12:56 PM, Borislav Petkov wrote:
> 
> I think it's good enough for perf, but I'm not sure whether other codes need
> the CPU type information.
> 
> Ricardo, do you know?
> 
> Maybe we should implement a generic function as below for this?
> (Not test. Just use as an example.)
> 
> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> index a66c1fd..679f5fe 100644
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -2056,3 +2056,11 @@ void arch_smt_update(void)
>  	/* Check whether IPI broadcasting can be enabled */
>  	apic_smt_update();
>  }
> +
> +u32 x86_read_hybrid_type(void)
> +{
> +	if (cpu_feature_enabled(X86_FEATURE_HYBRID_CPU))
> +		return cpuid_eax(0x0000001a);
> +
> +	return 0;
> +}

Machine check logging will want to include this in "struct mce".

But ok to pick it up with a function like you describe above.

-Tony