Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: FLtx/Uo0TKmgpRs8REt6uoJYD14gnkSu+DcdxGN1Bx12QD2EmiR6AWTIMhLJzk7iXibapHe0na
 SJHAAPjiJ6jg==
IronPort-SDR: U11Fj0FVC8pr92M/O5i2/+Qyw1XG4JcwB7u6TrOG4syTpu8p4xAjMX5hLB4TZyHsQ1nVUmSLrY
 EH5kWVOby33Q==
Subject: Re: [PATCH 02/49] x86/cpu: Describe hybrid CPUs in cpuinfo_x86
To:     Borislav Petkov <bp@alien8.de>
Cc:     peterz@infradead.org, acme@kernel.org, mingo@kernel.org,
        linux-kernel@vger.kernel.org, tglx@linutronix.de,
        namhyung@kernel.org, jolsa@redhat.com, ak@linux.intel.com,
        yao.jin@linux.intel.com, alexander.shishkin@linux.intel.com,
        adrian.hunter@intel.com,
        Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@intel.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        "Ravi V. Shankar" <ravi.v.shankar@intel.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Len Brown <len.brown@intel.com>,
        Tony Luck <tony.luck@intel.com>
References: <1612797946-18784-1-git-send-email-kan.liang@linux.intel.com>
 <1612797946-18784-3-git-send-email-kan.liang@linux.intel.com>
 <20210208175640.GD18227@zn.tnic>
From:   "Liang, Kan" <kan.liang@linux.intel.com>
Message-ID: <cddc013c-5b48-f792-058c-009e43cfe547@linux.intel.com>
Date:   Mon, 8 Feb 2021 14:04:24 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.0
MIME-Version: 1.0
In-Reply-To: <20210208175640.GD18227@zn.tnic>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2/8/2021 12:56 PM, Borislav Petkov wrote:
> On Mon, Feb 08, 2021 at 07:24:59AM -0800, kan.liang@linux.intel.com wrote:
>> diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h
>> index c20a52b..1f25ac9 100644
>> --- a/arch/x86/include/asm/processor.h
>> +++ b/arch/x86/include/asm/processor.h
>> @@ -139,6 +139,16 @@ struct cpuinfo_x86 {
>>   	u32			microcode;
>>   	/* Address space bits used by the cache internally */
>>   	u8			x86_cache_bits;
>> +	/*
>> +	 * In hybrid processors, there is a CPU type and a native model ID. The
>> +	 * CPU type (x86_cpu_type[31:24]) describes the type of micro-
>> +	 * architecture families. The native model ID (x86_cpu_type[23:0])
>> +	 * describes a specific microarchitecture version. Combining both
>> +	 * allows to uniquely identify a CPU.
>> +	 *
>> +	 * Please note that the native model ID is not related to x86_model.
>> +	 */
>> +	u32			x86_cpu_type;
> 
> Why are you adding it here instead of simply using
> X86_FEATURE_HYBRID_CPU at the call site?
> 
> How many uses in this patchset?
> 
> /me searches...
> 
> Exactly one.
> 
> Just query X86_FEATURE_HYBRID_CPU at the call site and read what you
> need from CPUID and use it there - no need for this.
> 

I think it's good enough for perf, but I'm not sure whether other codes 
need the CPU type information.

Ricardo, do you know?

Maybe we should implement a generic function as below for this?
(Not test. Just use as an example.)

diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index a66c1fd..679f5fe 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -2056,3 +2056,11 @@ void arch_smt_update(void)
  	/* Check whether IPI broadcasting can be enabled */
  	apic_smt_update();
  }
+
+u32 x86_read_hybrid_type(void)
+{
+	if (cpu_feature_enabled(X86_FEATURE_HYBRID_CPU))
+		return cpuid_eax(0x0000001a);
+
+	return 0;
+}


Thanks,
Kan