Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210206150833.42120-1-leo.yan@linaro.org> <20210206150833.42120-9-leo.yan@linaro.org>
 <20210208205009.GF2077938@xps15>
In-Reply-To: <20210208205009.GF2077938@xps15>
From:   Mike Leach <mike.leach@linaro.org>
Date:   Mon, 8 Feb 2021 21:15:41 +0000
Message-ID: <CAJ9a7Vj0T7Yh8mduqAMJtmBwxjWBgEa1O5CO1gw8gYqX8hRmyQ@mail.gmail.com>
Subject: Re: [PATCH v3 8/8] Documentation: coresight: Add PID tracing description
To:     Mathieu Poirier <mathieu.poirier@linaro.org>
Cc:     Leo Yan <leo.yan@linaro.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Jonathan Corbet <corbet@lwn.net>,
        John Garry <john.garry@huawei.com>,
        Will Deacon <will@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Daniel Kiss <Daniel.Kiss@arm.com>,
        Denis Nikitin <denik@chromium.org>,
        Al Grant <al.grant@arm.com>,
        Coresight ML <coresight@lists.linaro.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

I think Suzuki may be on holiday for two weeks. But this does appear
to pick up both mine and his suggestions.
Suzuki gave his conditional reviewed by in the last patch.

Reviewed-by: Mike Leach <mike.leach@linaro.org>


On Mon, 8 Feb 2021 at 20:50, Mathieu Poirier <mathieu.poirier@linaro.org> wrote:
>
> On Sat, Feb 06, 2021 at 11:08:33PM +0800, Leo Yan wrote:
> > After support the PID tracing for the kernel in EL1 or EL2, the usage
> > gets more complicated.
> >
> > This patch gives description for the PMU formats of contextID configs,
> > this can help users to understand how to control the knobs for PID
> > tracing when the kernel is in different ELs.
> >
> > Signed-off-by: Leo Yan <leo.yan@linaro.org>
>
> As I indicated I have picked up the kernel patches in this set and there should
> be a new patchset sent to Arnaldo.  The only thing left is this patch and I will
> give time to Mike and Suzuki to look at it before I add it to my tree.
>
> Thanks,
> Mathieu
>
> > ---
> >  Documentation/trace/coresight/coresight.rst | 32 +++++++++++++++++++++
> >  1 file changed, 32 insertions(+)
> >
> > diff --git a/Documentation/trace/coresight/coresight.rst b/Documentation/trace/coresight/coresight.rst
> > index 0b73acb44efa..169749efd8d1 100644
> > --- a/Documentation/trace/coresight/coresight.rst
> > +++ b/Documentation/trace/coresight/coresight.rst
> > @@ -512,6 +512,38 @@ The --itrace option controls the type and frequency of synthesized events
> >  Note that only 64-bit programs are currently supported - further work is
> >  required to support instruction decode of 32-bit Arm programs.
> >
> > +2.2) Tracing PID
> > +
> > +The kernel can be built to write the PID value into the PE ContextID registers.
> > +For a kernel running at EL1, the PID is stored in CONTEXTIDR_EL1.  A PE may
> > +implement Arm Virtualization Host Extensions (VHE), which the kernel can
> > +run at EL2 as a virtualisation host; in this case, the PID value is stored in
> > +CONTEXTIDR_EL2.
> > +
> > +perf provides PMU formats that program the ETM to insert these values into the
> > +trace data; the PMU formats are defined as below:
> > +
> > +  "contextid1": Available on both EL1 kernel and EL2 kernel.  When the
> > +                kernel is running at EL1, "contextid1" enables the PID
> > +                tracing; when the kernel is running at EL2, this enables
> > +                tracing the PID of guest applications.
> > +
> > +  "contextid2": Only usable when the kernel is running at EL2.  When
> > +                selected, enables PID tracing on EL2 kernel.
> > +
> > +  "contextid":  Will be an alias for the option that enables PID
> > +                tracing.  I.e,
> > +                contextid == contextid1, on EL1 kernel.
> > +                contextid == contextid2, on EL2 kernel.
> > +
> > +perf will always enable PID tracing at the relevant EL, this is accomplished by
> > +automatically enable the "contextid" config - but for EL2 it is possible to make
> > +specific adjustments using configs "contextid1" and "contextid2", E.g. if a user
> > +wants to trace PIDs for both host and guest, the two configs "contextid1" and
> > +"contextid2" can be set at the same time:
> > +
> > +  perf record -e cs_etm/contextid1,contextid2/u -- vm
> > +
> >
> >  Generating coverage files for Feedback Directed Optimization: AutoFDO
> >  ---------------------------------------------------------------------
> > --
> > 2.25.1
> >


--
Mike Leach
Principal Engineer, ARM Ltd.
Manchester Design Centre. UK