Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] selftests: breakpoints: Use correct error messages in
 breakpoint_test_arm64.c
To:     Tiezhu Yang <yangtiezhu@loongson.cn>, Shuah Khan <shuah@kernel.org>
Cc:     linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <1612506839-27225-1-git-send-email-yangtiezhu@loongson.cn>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <db7c4310-503b-f84f-99a6-0d8d58da99b6@linuxfoundation.org>
Date:   Mon, 8 Feb 2021 17:05:52 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <1612506839-27225-1-git-send-email-yangtiezhu@loongson.cn>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/4/21 11:33 PM, Tiezhu Yang wrote:
> When call ptrace(PTRACE_CONT, ...) failed, use correct error messages.
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
>   tools/testing/selftests/breakpoints/breakpoint_test_arm64.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> index ad41ea6..e704181 100644
> --- a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> +++ b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> @@ -145,7 +145,7 @@ static bool run_test(int wr_size, int wp_size, int wr, int wp)
>   
>   	if (ptrace(PTRACE_CONT, pid, NULL, NULL) < 0) {
>   		ksft_print_msg(
> -			"ptrace(PTRACE_SINGLESTEP) failed: %s\n",
> +			"ptrace(PTRACE_CONT) failed: %s\n",
>   			strerror(errno));
>   		return false;
>   	}
> @@ -159,7 +159,7 @@ static bool run_test(int wr_size, int wp_size, int wr, int wp)
>   	}
>   	alarm(0);
>   	if (WIFEXITED(status)) {
> -		ksft_print_msg("child did not single-step\n");
> +		ksft_print_msg("child exited prematurely\n");
>   		return false;
>   	}
>   	if (!WIFSTOPPED(status)) {
> 

Thank you. Applied to linux-kselftest next for 5.12-rc1

thanks,
-- Shuah