Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1612780213-84583-1-git-send-email-yang.lee@linux.alibaba.com>
In-Reply-To: <1612780213-84583-1-git-send-email-yang.lee@linux.alibaba.com>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Mon, 8 Feb 2021 18:05:08 -0800
Message-ID: <CAEf4Bzaugcu=fYrZxkkA+fssZPJooWbwQH4hGJTJReGR63Vkdw@mail.gmail.com>
Subject: Re: [PATCH] selftests: bpf: remove unneeded semicolon
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     Shuah Khan <shuah@kernel.org>, Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>, Martin Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        john fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Feb 8, 2021 at 2:30 AM Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> Eliminate the following coccicheck warning:
> ./tools/testing/selftests/bpf/test_flow_dissector.c:506:2-3: Unneeded
> semicolon
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---

Applied to bpf-next, changing subject to have more canonical
"selftests/bpf: " prefix. Thanks.

>  tools/testing/selftests/bpf/test_flow_dissector.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/test_flow_dissector.c b/tools/testing/selftests/bpf/test_flow_dissector.c
> index 01f0c63..571cc07 100644
> --- a/tools/testing/selftests/bpf/test_flow_dissector.c
> +++ b/tools/testing/selftests/bpf/test_flow_dissector.c
> @@ -503,7 +503,7 @@ static int do_rx(int fd)
>                 if (rbuf != cfg_payload_char)
>                         error(1, 0, "recv: payload mismatch");
>                 num++;
> -       };
> +       }
>
>         return num;
>  }
> --
> 1.8.3.1
>