Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp225316pxb; Mon, 8 Feb 2021 21:20:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJyn8gUGQKKoIBYFTpTXmPibYiuRzU7Qr0YoMM9YTWp/Z38COaT7bXR+MtcnNso08nbzD0c4 X-Received: by 2002:a17:906:ecb6:: with SMTP id qh22mr21002184ejb.252.1612848043868; Mon, 08 Feb 2021 21:20:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612848043; cv=none; d=google.com; s=arc-20160816; b=IucTfy88fphVhQwB+ra/oknjdRqG6X82QB4untGoQ6Bk+FprjFUrPRAkkcazOha1mG 5UM/oiuabuR/TX5v3bAtDe/Rt/9zGsF08TjQ4LCAsyWPojvlfkyPYBouLquxndaWHKCX klT8M3/qksB2y5uobMFiepkcmGINMqWb0vkBvjRlTtqCA7HW7g2WN22cHVf3zf6ny7M0 Hb/jyMABUHTQkYSJ/kLcFGD3XENwMw/ITxvwe0PDvn0ahM28Cp0VyH4lxM1XUhgj2m7P +KWz7Jqg4pAKZyindu81lNnxR8nNNeBuoZu9Ks1493ImeVFv3oUkwqqaMEZ3a/5ipw4m iFsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=L8BK9D+uuYU7ZhrW2feVoLIu8IHxKir02v9HrkdcSyQ=; b=sbaKHCYmJeUzvdQkQUIOPn8zs7IO1gyYyaAb1aj9lvfXWXkZF+EdPb6hWNUG4cfc+d DPVTCpx1IWlh0vCCnmRLOXFstcUay/wHiK0aMkFj/ARh2d1KfkoCWljZlff8IC5dEgOM Cwl/VZ0YRuV+BFBP3wEyOVtAkv8CCTWi2QiR6CD54AuM9A7J33CvmYV8De79ZUsosVFN ZxFe4CQtcRnteXiDTN554ATEySH4doBiTWa6t+x2nEFrk/FlyjuNqRHKqhhsHqYJwmDY ZD1JmM2+7O0MyhS4KUXBoPrSuPyOMqu49syWz11Cf0gMC93U0j0Kp1SuIHxXEzEpqGHn gg7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b="B/QqkRE6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hs28si13756891ejc.141.2021.02.08.21.20.16; Mon, 08 Feb 2021 21:20:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b="B/QqkRE6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229666AbhBIFTe (ORCPT + 99 others); Tue, 9 Feb 2021 00:19:34 -0500 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:8523 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbhBIFTe (ORCPT ); Tue, 9 Feb 2021 00:19:34 -0500 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 08 Feb 2021 21:18:54 -0800 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 9 Feb 2021 05:18:53 +0000 Received: from MacBook-Pro-10.local (172.20.145.6) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 9 Feb 2021 05:18:53 +0000 Subject: Re: [PATCH v2] mm: cma: support sysfs To: Minchan Kim CC: Andrew Morton , linux-mm , LKML , , , , References: <20210208180142.2765456-1-minchan@kernel.org> <43cd6fc4-5bc5-50ec-0252-ffe09afd68ea@nvidia.com> From: John Hubbard Message-ID: <3cf67381-9b5a-56ee-2a8f-047955c84128@nvidia.com> Date: Mon, 8 Feb 2021 21:18:52 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To DRHQMAIL107.nvidia.com (10.27.9.16) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1612847934; bh=L8BK9D+uuYU7ZhrW2feVoLIu8IHxKir02v9HrkdcSyQ=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=B/QqkRE6/oM+57E2Rs9HLW6n93XxcfSSDlZGkgrlo1H0SYqiAZcLql1cTJG2z1YNU y0p9JTd6Ia8zC303LeT3YE6aC1Co6buUcI2BEgeyMES7sxqH3v5mRqKkzzUxFGkmeH mIgjNftb7E+r3gNe+y4FTqpF5vxPawP1j2IRozglnAgaUrdfHVzFgNE2J456mZnEfY iX/ibQmDHUU4xvvyONbcuof9GEIkEJdBRmNKKwx+ESaM9qQnyCCcwsOEQngdMMkStD KSmhxOoBogx2hhFj6+IRyK/NDI9qsdi1y7U2q/A9Zh7W+qw/fXEU/bd0cc3A9Guhd4 MDnbsAc2EhyeA== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/8/21 8:19 PM, Minchan Kim wrote: > On Mon, Feb 08, 2021 at 05:57:17PM -0800, John Hubbard wrote: >> On 2/8/21 3:36 PM, Minchan Kim wrote: >> ... >>>>> char name[CMA_MAX_NAME]; >>>>> +#ifdef CONFIG_CMA_SYSFS >>>>> + struct cma_stat *stat; >>>> >>>> This should not be a pointer. By making it a pointer, you've added a bunch of pointless >>>> extra code to the implementation. >>> >>> Originally, I went with the object lifetime with struct cma as you >>> suggested to make code simple. However, Greg KH wanted to have >>> release for kobj_type since it is consistent with other kboject >>> handling. >> >> Are you talking about the kobj in your new struct cma_stat? That seems >> like circular logic if so. I'm guessing Greg just wanted kobj methods >> to be used *if* you are dealing with kobjects. That's a narrower point. >> >> I can't imagine that he would have insisted on having additional >> allocations just so that kobj freeing methods could be used. :) > > I have no objection if Greg agree static kobject is okay in this > case. Greg? > What I meant is, no kobject at all in the struct cma_stat member variable. The lifetime of the cma_stat member is the same as the containing struct, so no point in putting a kobject into it. thanks, -- John Hubbard NVIDIA