Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932155AbWIVTGs (ORCPT ); Fri, 22 Sep 2006 15:06:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932160AbWIVTGs (ORCPT ); Fri, 22 Sep 2006 15:06:48 -0400 Received: from omx2-ext.sgi.com ([192.48.171.19]:53964 "EHLO omx2.sgi.com") by vger.kernel.org with ESMTP id S932155AbWIVTGr (ORCPT ); Fri, 22 Sep 2006 15:06:47 -0400 Date: Fri, 22 Sep 2006 12:06:33 -0700 (PDT) From: Christoph Lameter To: Andrew Morton cc: David Rientjes , KAMEZAWA Hiroyuki , kmannth@us.ibm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] do not free non slab allocated per_cpu_pageset In-Reply-To: <20060922115646.fd1040e8.akpm@osdl.org> Message-ID: References: <1158884252.5657.38.camel@keithlap> <20060921174134.4e0d30f2.akpm@osdl.org> <1158888843.5657.44.camel@keithlap> <20060922112427.d5f3aef6.kamezawa.hiroyu@jp.fujitsu.com> <20060921200806.523ce0b2.akpm@osdl.org> <20060922123045.d7258e13.kamezawa.hiroyu@jp.fujitsu.com> <20060921204629.49caa95f.akpm@osdl.org> <20060922113924.014ce28f.akpm@osdl.org> <20060922115646.fd1040e8.akpm@osdl.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 997 Lines: 23 On Fri, 22 Sep 2006, Andrew Morton wrote: > > > > > I think I preferred my earlier fix, recently reworked as: > > > > The problem is though that the pcp pointers must point to the static pcp > > arrays for bootup to succeed under NUMA. Your patch may work under SMP. > > For NUMA you may zap pointers to valid static pcps. > > This is unclear to me. Do you mean "the pcps must be usable during > process_zones()'s call to kmalloc_node())" or do you mean "the pcps must > always be usable" (in which case more work needs to be done) or what? The pcps must be usable during process_zones() for NUMA bootstrap. As far as I recall: A cpu is booted with the static arrays and later process_zones is replacing the references to the static arrays. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/