Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Ioana Ciornei <ioana.ciornei@nxp.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
CC:     Ioana Ciornei <ciorneiioana@gmail.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        Laurentiu Tudor <laurentiu.tudor@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] bus: fsl-mc: Fix test for end of loop
Thread-Topic: [PATCH 1/3] bus: fsl-mc: Fix test for end of loop
Thread-Index: AQHW/j0+uozycm85P06YEWbvXtn5UqpOnDUAgADv/AA=
Date:   Tue, 9 Feb 2021 09:17:07 +0000
Message-ID: <20210209091706.ug7cjdn5rripnqv7@skbuf>
References: <20210208170949.3070898-1-ciorneiioana@gmail.com>
 <20210208170949.3070898-2-ciorneiioana@gmail.com>
 <20210208185810.GM20820@kadam>
In-Reply-To: <20210208185810.GM20820@kadam>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <73DEFE167F648A4FBF5D54F3DEE56F9A@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 561f0317-41d9-4c38-a0d6-08d8ccdb7936
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2021 09:17:07.5043
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: upYsM8IJsC/DRy280II/TElJ5tTPWY7G8g9bWzfJtIgFUlq5Oqm0DU5CGsKO30sbsoIbmRkpbRNARy3T90st2Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7006
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 08, 2021 at 09:58:10PM +0300, Dan Carpenter wrote:
> On Mon, Feb 08, 2021 at 07:09:47PM +0200, Ioana Ciornei wrote:
> > From: Dan Carpenter <dan.carpenter@oracle.com>
> >=20
> > The "desc" pointer can't possibly be NULL here.  If we can't find the
> > correct "desc" then tt points to the last element of the
> > fsl_mc_accepted_cmds[] array.  Fix this by testing if
> > "i =3D=3D FSL_MC_NUM_ACCEPTED_CMDS" instead.
> >=20
> > Fixes: 2cf1e703f066 ("bus: fsl-mc: add fsl-mc userspace support")
> > Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>=20
> Generally the tags are expected to go in chronological order:
>=20
> Fixes: commit
> Signed-off-by: Author
> Acked-by: Whoever
> Signed-off-by: Maintainer
>=20

Thanks! I didn't know that.

Ioana=