Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 9 Feb 2021 10:37:34 +0100 (CET)
From:   Jiri Kosina <jikos@kernel.org>
To:     =?ISO-8859-15?Q?Filipe_La=EDns?= <lains@archlinux.org>
cc:     Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        =?ISO-8859-15?Q?Filipe_La=EDns?= <lains@riseup.net>
Subject: Re: [PATCH] HID: logitech-dj: add support for the new lightspeed
 connection iteration
In-Reply-To: <20210123180220.3056430-1-lains@archlinux.org>
Message-ID: <nycvar.YFH.7.76.2102091037250.28696@cbobk.fhfr.pm>
References: <20210123180220.3056430-1-lains@archlinux.org>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Sat, 23 Jan 2021, Filipe Laíns wrote:

> From: Filipe Laíns <lains@riseup.net>
> 
> This new connection type is the new iteration of the Lightspeed
> connection and will probably be used in some of the newer gaming
> devices. It is currently use in the G Pro X Superlight.
> 
> This patch should be backported to older versions, as currently the
> driver will panic when seing the unsupported connection. This isn't
> an issue when using the receiver that came with the device, as Logitech
> has been using different PIDs when they change the connection type, but
> is an issue when using a generic receiver (well, generic Lightspeed
> receiver), which is the case of the one in the Powerplay mat. Currently,
> the only generic Ligthspeed receiver we support, and the only one that
> exists AFAIK, is ther Powerplay.
> 
> As it stands, the driver will panic when seeing a G Pro X Superlight
> connected to the Powerplay receiver and won't send any input events to
> userspace! The kernel will warn about this so the issue should be easy
> to identify, but it is still very worrying how hard it will fail :(

Applied to for-5.11/upstream-fixes, thanks Filipe.

-- 
Jiri Kosina
SUSE Labs