Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp396585pxb; Tue, 9 Feb 2021 03:17:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJxPFPXhU4PbBwnKMUdWVqFQOJdd563yseu1Ucs7QeK8cHrsRqwKtrG1lNhZz8EJxccQZbTa X-Received: by 2002:a17:906:30cd:: with SMTP id b13mr21699756ejb.336.1612869445510; Tue, 09 Feb 2021 03:17:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612869445; cv=none; d=google.com; s=arc-20160816; b=HonhmDHrF5oo/ubZqCTbiXZsRbz9kbzNOcxccc6vqq431nMKJlPDUYQO+rbb/1kCol 8zOwOrzi56kKJanYlK9wvwYXXUxbHjv4sspy2TT5dnMWHNP/TpGApGZs4Ng2rm1JLfw0 oEYFHHE2CbDwOEVupzcfl9N+fmVuTxvRaci75U66A/LG5f1nDolQEDj9niDjf+KFnAny S155z8qy+gLaw9vZi18fjK+oVqS07YRGZrjNCxR9bLVT2MCQKVvxwF7AFs4MV03YgACm ODHN0x/8KG8RSzJ41LmJ20hVCKexoifXod/EeMcQI7VricvHDm2VqgoTtBThmkBF/8pL dHsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=LTGYAGEGB3bzpkyro2uhygLwv1IWIDXQiCYNW7uPhM0=; b=i0Q1fYDEdbl4Wmk9RtWM+twrA+PbVvgWAj9Or42UcZrJlJi8mMQ2Qh3xt5eo3wKvjA qxES5jvqos9bvuQtoUCOlCJN8C8k9SpcchYXQiYhq/n3NNmZ79GJ8urhPnbK4cl5bl1S 71w9jU/KTcbDOxvbgG9zaCJN3ActPTNiXoaK1FUgaS/oQfPIJJFtYarix3IzVMCmlTm4 yCBQZdfteHy0GIf2MUd0LTEobHdisPV5g65g2LHVNhK+8uBK3FQNJW0ehmEKdz8VZHXb aF1vbKxA49Zu1OfIACYBk3lhQN6pVntYNnGBbBLOdL7vJgkt7JYz5Gaflo5b335PgUEd 5QhQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hs7si4236260ejc.128.2021.02.09.03.17.00; Tue, 09 Feb 2021 03:17:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229925AbhBILQB (ORCPT + 99 others); Tue, 9 Feb 2021 06:16:01 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:12882 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229984AbhBILLx (ORCPT ); Tue, 9 Feb 2021 06:11:53 -0500 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4DZgC819fdz7jJr; Tue, 9 Feb 2021 19:09:40 +0800 (CST) Received: from localhost.localdomain (10.67.165.24) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.498.0; Tue, 9 Feb 2021 19:10:57 +0800 From: Yicong Yang To: , , , , , , , , , , , , , , CC: , , Subject: [PATCH v2 0/4] Use subdir-ccflags-* to inherit debug flag Date: Tue, 9 Feb 2021 19:08:15 +0800 Message-ID: <1612868899-9185-1-git-send-email-yangyicong@hisilicon.com> X-Mailer: git-send-email 2.8.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Few drivers use ccflags-* in their top directory to enable -DDEBUG, but don't have config options to enable debug in the sub-directories, or they use per subdirectory ccflags-* to have DEBUG with the same kconfig option. Considering they intends to enable debug for all the files under the directory with the same kconfig option, it will be clearer to use subdir-ccflags-* instead of ccflags-* to inherit the debug settings from Kconfig when traversing subdirectories. We primarily find this issue when debugging PCIe and thought other drivers may also have this issues. Previous discussion can be find at https://lore.kernel.org/linux-pci/1612438215-33105-1-git-send-email-yangyicong@hisilicon.com/ Change since v1: - reword the commits to illustrate the reasons of the change and the benefits. v1: https://lore.kernel.org/lkml/1612518255-23052-1-git-send-email-yangyicong@hisilicon.com/ Junhao He (4): driver core: Use subdir-ccflags-* to inherit debug flag hwmon: Use subdir-ccflags-* to inherit debug flag pps: Use subdir-ccflags-* to inherit debug flag staging: comedi: Use subdir-ccflags-* to inherit debug flag drivers/base/Makefile | 2 +- drivers/base/power/Makefile | 2 -- drivers/hwmon/Makefile | 2 +- drivers/pps/Makefile | 2 +- drivers/staging/comedi/Makefile | 2 +- drivers/staging/comedi/drivers/Makefile | 1 - drivers/staging/comedi/drivers/tests/Makefile | 2 -- drivers/staging/comedi/kcomedilib/Makefile | 2 -- 8 files changed, 4 insertions(+), 11 deletions(-) -- 2.8.1