Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp451043pxb; Tue, 9 Feb 2021 04:44:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJxIMA9wrgJmNwyYYOI+DlDEPJxMwcTfyqwuteuphu8kn0WwhJNeb+f9L6cnVT7UEa55nlPW X-Received: by 2002:a50:e0c1:: with SMTP id j1mr22473478edl.253.1612874683024; Tue, 09 Feb 2021 04:44:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612874683; cv=none; d=google.com; s=arc-20160816; b=X0Z2WzluQpeUpbC0y4CeEHcQeDObor2yRxS3ZR/VESunml2uLMZghygBx9aSl0Rp1i SN3IvfbjnwmK3fTAkbWu+pYL0au6X/vnRa6T8/ftKGhXHWcKO1TzCmZI6HC5EnxumtAY aKif4hBqvqOV024v4YtZQNN1GqS8BREmLwMOmfkKFsie+xsELjQZXdqvUHa4yB+PfuMh TUlg0+2EnHBvLEP+0QpIdQPk5eEJJbgh78ZgpOt702kKDWTkdcAMG8x2lbI7B+VyDItd 1haxJ8Bm25CnNM6bWmJXlxnBt2nS5li1Mr7g0QOgwbU1/prj5XWhab6nh6DQZEPd1MvF bMFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=y1km95f4gtgIlrTlDInkEcPErlLWwjXf8eGZ4wuAOo0=; b=X30qF94Ckm8viFdheFUvegnYJQSApPHVVyZqUxYONq8wz/L0aucGMfAuroMxPvNBIV mP3iyJ2RORCBeiKsNQvlj7bS/dzw+FHMqFKrM9xylxrAVTmBCpsbP5reLwE7V0WfDYFB em0gJ4E5d4vxiJTWNHPxGsUwrkFEA71VQQ6xNU02WQB8zDc5yh+/OyHVi6GmqE+stsQn 7bwsN3CRVIGG29tDv/z2rtpIMDIixGLcn4+SNrsDj0dHy3/H3bwHEG5ba4SQBUMeBH1f /F8DULoKFNITYw6siPPpZ5VlUjtio+XZnD3f9Eq30RaWxBYlvqYHH+yIvSmYMNyGczdk uwZQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o11si9159539ejr.35.2021.02.09.04.44.19; Tue, 09 Feb 2021 04:44:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230349AbhBIMmo (ORCPT + 99 others); Tue, 9 Feb 2021 07:42:44 -0500 Received: from mx2.cyber.ee ([193.40.6.72]:45219 "EHLO mx2.cyber.ee" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230264AbhBIMkw (ORCPT ); Tue, 9 Feb 2021 07:40:52 -0500 Subject: Re: [PATCH v3] sched/topology: fix the issue groups don't span domain->span for NUMA diameter > 2 To: Barry Song , valentin.schneider@arm.com, vincent.guittot@linaro.org, mgorman@suse.de, mingo@kernel.org, peterz@infradead.org, dietmar.eggemann@arm.com, morten.rasmussen@arm.com, linux-kernel@vger.kernel.org Cc: linuxarm@openeuler.org, xuwei5@huawei.com, liguozhu@hisilicon.com, tiantao6@hisilicon.com, wanghuiqiang@huawei.com, prime.zeng@hisilicon.com, jonathan.cameron@huawei.com, guodong.xu@linaro.org References: <20210209082125.22176-1-song.bao.hua@hisilicon.com> From: Meelis Roos Message-ID: Date: Tue, 9 Feb 2021 14:40:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210209082125.22176-1-song.bao.hua@hisilicon.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I did a rudimentary benchmark on the same 8-node Sun Fire X4600-M2, on top of todays 5.11.0-rc7-00002-ge0756cfc7d7c. The test: building clean kernel with make -j64 after make clean and drop_caches. While running clean kernel / 3 tries): real 2m38.574s user 46m18.387s sys 6m8.724s real 2m37.647s user 46m34.171s sys 6m11.993s real 2m37.832s user 46m34.910s sys 6m12.013s While running patched kernel: real 2m40.072s user 46m22.610s sys 6m6.658s for real time, seems to be 1.5s-2s slower out of 160s (noise?) User and system time are slightly less, on the other hand, so seems good to me. -- Meelis Roos