Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp465014pxb; Tue, 9 Feb 2021 05:06:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJyCYCYQw6MMs6L6pHp4Amu9rtGLx/3MW/uDmnUceNzxcjp29wbZp5BoKnuVYtxWL7vIfEYG X-Received: by 2002:a7b:c852:: with SMTP id c18mr3411250wml.118.1612875966471; Tue, 09 Feb 2021 05:06:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612875966; cv=none; d=google.com; s=arc-20160816; b=NKccuop5J6JcV7iIXccrzEk6lfHq2dFLyRgCPhaA6P/GRyHjOe+WifTb+DOsat33O+ 6iA8H/J/KFcL8B+7m3YgsMU1jBrPoeohWgJMj6cVafmvSjPYxYO3n3EtMXGUnO8DM+5r jyLsKQnqGug4ADsU6WxxHxEpK6YoLraUi5+gdBjXIv8VgVOWwX15SdvACiqvC0p4Qdc+ ZrFudlnslk6I6nU0WfXvgSHjwKez3WUm3+xdKkaPKvRyVmdZPOHdyL4aF4NoAWgmWvk/ X93CYYht3CwXlFQQThCBO44+nkIOxnantiNflBH+Njmm04QKa1jhdEvMrOt9Gh/tXZoE U1/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=z8EMZ3WI1OeJSSlljTHtMzqvazHug8S1yeNui2xta0w=; b=sXQSeDygN0AOJOFWBELsoCG5NDK7HH4Nphpcb6KK89VFfiYqsb2t/Y6dWFwk6lkrej m6mKIAGcnQIXr0ZxFXpEtis0nAb4dapUu3UuqZoXyAZkaF49axkRiDwilYpxwW1Eky5H f2UQKmFZ626P6AEjwuv5oUE9dbtJ9G0o7xBkpoJPRh5Yybf4vQA4YchpFEGyTIYWyCbB uZxlqikV45Y9FscKttVgNC7vclFgMOjGIjoTPxJw52QdPQpZ1m7d32EO+3yHmTse63su iqkVztM2+I85hyS+M3kZV7jIDfaSiBZJKksKpTufkxg3tWgHzWFf1VbgKDRx/SVRwIFt Uhzg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id fx15si13193452ejb.27.2021.02.09.05.05.38; Tue, 09 Feb 2021 05:06:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230514AbhBINDO (ORCPT + 99 others); Tue, 9 Feb 2021 08:03:14 -0500 Received: from mx2.suse.de ([195.135.220.15]:45082 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230422AbhBINCG (ORCPT ); Tue, 9 Feb 2021 08:02:06 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7550BAFD2; Tue, 9 Feb 2021 13:00:45 +0000 (UTC) From: Nicolas Saenz Julienne To: f.fainelli@gmail.com, linux-kernel@vger.kernel.org, Lee Jones , Nicolas Saenz Julienne , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com Cc: linux-rpi-kernel@lists.infradead.org, phil@raspberrypi.com, wahrenst@gmx.net, linux-arm-kernel@lists.infradead.org, mripard@kernel.org, eric@anholt.net Subject: [RFC/PATCH v2 07/16] mfd: bcm2835-pm: Use 'reg-names' to get resources Date: Tue, 9 Feb 2021 13:59:03 +0100 Message-Id: <20210209125912.3398-8-nsaenzjulienne@suse.de> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210209125912.3398-1-nsaenzjulienne@suse.de> References: <20210209125912.3398-1-nsaenzjulienne@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If available in firmware, find resources by their 'reg-names' position instead of relying on hardcoded offsets. Care is taken to support old firmware nonetheless. Signed-off-by: Nicolas Saenz Julienne --- drivers/mfd/bcm2835-pm.c | 56 ++++++++++++++++++++++++++-------------- 1 file changed, 37 insertions(+), 19 deletions(-) diff --git a/drivers/mfd/bcm2835-pm.c b/drivers/mfd/bcm2835-pm.c index 836343e69f43..182ccdc2a06b 100644 --- a/drivers/mfd/bcm2835-pm.c +++ b/drivers/mfd/bcm2835-pm.c @@ -25,9 +25,38 @@ static const struct mfd_cell bcm2835_power_devs[] = { { .name = "bcm2835-power" }, }; +static int bcm2835_pm_get_pdata(struct platform_device *pdev, + struct bcm2835_pm *pm) +{ + /* If no 'reg-names' property is found we can assume we're using old + * firmware. + */ + if (!of_find_property(pm->dev->of_node, "reg-names", NULL)) { + dev_warn(pm->dev, "Old devicetree detected, please update your firmware.\n"); + + pm->base = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(pm->base)) + return PTR_ERR(pm->base); + + pm->rpivid_asb = devm_platform_ioremap_resource(pdev, 1); + if (IS_ERR(pm->rpivid_asb)) + pm->rpivid_asb = NULL; + } else { + pm->base = devm_platform_ioremap_resource_byname(pdev, "pm"); + if (IS_ERR(pm->base)) + return PTR_ERR(pm->base); + + pm->rpivid_asb = devm_platform_ioremap_resource_byname(pdev, + "rpivid_asb"); + if (IS_ERR(pm->base)) + pm->rpivid_asb = NULL; + } + + return 0; +} + static int bcm2835_pm_probe(struct platform_device *pdev) { - struct resource *res; struct device *dev = &pdev->dev; struct bcm2835_pm *pm; int ret; @@ -39,10 +68,9 @@ static int bcm2835_pm_probe(struct platform_device *pdev) pm->dev = dev; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - pm->base = devm_ioremap_resource(dev, res); - if (IS_ERR(pm->base)) - return PTR_ERR(pm->base); + ret = bcm2835_pm_get_pdata(pdev, pm); + if (ret) + return ret; ret = devm_mfd_add_devices(dev, -1, bcm2835_pm_devs, ARRAY_SIZE(bcm2835_pm_devs), @@ -54,20 +82,10 @@ static int bcm2835_pm_probe(struct platform_device *pdev) * bcm2835-pm binding as the key for whether we can reference * the full PM register range and support power domains. */ - res = platform_get_resource(pdev, IORESOURCE_MEM, 1); - if (res) { - pm->rpivid_asb = devm_ioremap_resource(dev, res); - if (IS_ERR(pm->rpivid_asb)) - return PTR_ERR(pm->rpivid_asb); - - ret = devm_mfd_add_devices(dev, -1, - bcm2835_power_devs, - ARRAY_SIZE(bcm2835_power_devs), - NULL, 0, NULL); - if (ret) - return ret; - } - + if (pm->rpivid_asb) + return devm_mfd_add_devices(dev, -1, bcm2835_power_devs, + ARRAY_SIZE(bcm2835_power_devs), + NULL, 0, NULL); return 0; } -- 2.30.0