Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp575722pxb; Tue, 9 Feb 2021 07:32:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJzEQsFjoyNzP5BfuBtpGheJ3Wk0+oOBiWIcBNs58yirsqJM/ajsQmOKFlcg1hkmas1BZMmG X-Received: by 2002:a50:a6ce:: with SMTP id f14mr23292700edc.346.1612884754145; Tue, 09 Feb 2021 07:32:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612884754; cv=none; d=google.com; s=arc-20160816; b=FaltrnrWQYbfMRAypyimRImscTrLywv/97RS8Igvoqqe0uTT1hTF6ER83nvTkkyUEw o2Yc1kdvIMPdDb5puBLE6Hnlp5uvbFxixrGOJn3iHEAM1ohn6dOx6cl0RMbYel+SaEOR S+oR4r4pgQfita++Ql3JEk32Zqv6J4u8KsS8sXIArWx3PSuxJvzauieP6PqD6qF9jb9b jocoa/tuqk+IGOxwUuuHicjDx+0N+yCKSKwJR2hJJ3W7QF8s6Kg9bRN59mds+V7zTXix /mf41syjw5B+QQ5oHMdyGeIIo5+KE4lK/7ikpNO7vKCr2ECWUPj0AQcCOLjPaAF16ARf 5FCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=HeGD6+I/Cs2ZVAzM/f2bEdQ6Si5iou33votUBpUqwG4=; b=D50uuWUUGcrNq+dFNri4dHatBOpP2qFtZr8uFT5tvm8IgR5Rp9xOaGKoioARUCqtMb NoxvNqHrG4pfngXPoSbafx927CPAhfelZ8qWgHdLTgnEVyZ+e8lMYg96KjlbpxCRGhR7 Cl3FH6GsXuFwz5gDUPIVzG3MkGxaGjDNMjR+opYDSGNllaJraANhMZ4Lm8gR6gYJGYJy YneCf1SoLgsjBWjTeU4nn4m1ovZAjy3KE9ZRnUX+xLvyIuDcn8tR4vrkzZd9RUkqTppo OE1Z1XaAzJVkiJinaa8OHx4z2ZKAglK/QPxe5QAjHD/MMTo+/uUziMMq8khURXn9Zb+O BPiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GKd274qO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 4si8365952edc.221.2021.02.09.07.32.01; Tue, 09 Feb 2021 07:32:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GKd274qO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232458AbhBIP3c (ORCPT + 99 others); Tue, 9 Feb 2021 10:29:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231995AbhBIP32 (ORCPT ); Tue, 9 Feb 2021 10:29:28 -0500 Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93BE7C061786 for ; Tue, 9 Feb 2021 07:28:47 -0800 (PST) Received: by mail-qk1-x736.google.com with SMTP id t63so18319470qkc.1 for ; Tue, 09 Feb 2021 07:28:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HeGD6+I/Cs2ZVAzM/f2bEdQ6Si5iou33votUBpUqwG4=; b=GKd274qOkvO6lCn2UyoRyYKnv9aEEhMYtqmPeNOq/DNeG2lnp9WqdPhwodVNSk+p3X 2XYuYx95nWsRyymZYAbbb4SZLD4bNXRerQChOPAZv+UQ5xvnEzdQIjOi+TxsPq5lu+MQ UokLu+peT++x7Gtc+Dc2BkART/pN3P+hrYItv5Rh9vo3OwyzJC/M5i9qq9/dTWx6DUiM OytNr83a47lwk4jQOGzDvURBCSldZyKa5yc3A3u0CK86Ua6/c2kISHCYfEkT+WRpqouJ H3cX+dhCzdyYLOwDTR1zqGj+s0iZ9mM58Q9RSJFXtEAnv4shFWqmBZX4vpPJ+8sPEGXU wkrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=HeGD6+I/Cs2ZVAzM/f2bEdQ6Si5iou33votUBpUqwG4=; b=NKLzqyZL91CDzMF0nmN9Z3O15wZz9VyZZuv8MRt7iayCNOrZXapruNCDjb6uIL/yvT cvHB/CIT9AwmtT733OSNSNNbBnExCygLhPnYtp/+TvxYCwS+1aCjvhGkqWBocS8CcKT7 C1dvJ+VPkawXOq1nH+oPfuhOEFeA5g/FuqaFuzN6lWK6x2Cb8q2ArrMMG+c1sYVgAi5D gTXrzr4YjGM6sda2gwyZm0NWMbN6f8254D2khn8nRl52WPBqnaEZaJHTqY+7NP5/nlD7 +kbs4FhGZHdq815ylMqP+z5J/3l0MkxmvSOG1P4Mwcyivv/XxjUhCuAFi6yL328EoTPA NYbg== X-Gm-Message-State: AOAM533VjgrM+Dr3TrFNY1k7iVzSTzrcBxVGpEHrqQM7jxCaGNgr56bB IAizzRNyh7dWqTA5F+D5dQY= X-Received: by 2002:a37:6348:: with SMTP id x69mr1444621qkb.254.1612884526544; Tue, 09 Feb 2021 07:28:46 -0800 (PST) Received: from localhost (dhcp-6c-ae-f6-dc-d8-61.cpe.echoes.net. [72.28.8.195]) by smtp.gmail.com with ESMTPSA id x74sm17911085qkb.55.2021.02.09.07.28.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Feb 2021 07:28:46 -0800 (PST) Sender: Tejun Heo Date: Tue, 9 Feb 2021 05:28:43 -0500 From: Tejun Heo To: Odin Ugedal Cc: changhuaixin@linux.alibaba.com, bsegall@google.com, dietmar.eggemann@arm.com, juri.lelli@redhat.com, khlebnikov@yandex-team.ru, linux-kernel@vger.kernel.org, mgorman@suse.de, mingo@redhat.com, pauld@redhead.com, peterz@infradead.org, pjt@google.com, rostedt@goodmis.org, shanpeic@linux.alibaba.com, vincent.guittot@linaro.org, xiyou.wangcong@gmail.com Subject: Re: [PATCH v3 0/4] sched/fair: Burstable CFS bandwidth controller Message-ID: References: <20210121110453.18899-1-changhuaixin@linux.alibaba.com> <20210209131719.1193428-1-odin@uged.al> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210209131719.1193428-1-odin@uged.al> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Tue, Feb 09, 2021 at 02:17:19PM +0100, Odin Ugedal wrote: > A am not that familiar how cross subsystem patches like these are handled, but > I am still adding the Tejun Heo (cgroup maintainer) as a CC. Should maybe cc to > cgroup@ as well? Yeah, that'd be great. Given that it's mostly straight forward extension on an existing interface, things looks fine from cgroup side; however, please do add cgroup2 interface and documentation. One thing which has bene bothersome about the bandwidth interface is that we're exposing implementation details (window size and now burst size) instead of usage-centric requirements but that boat has already sailed, so... Thanks. -- tejun