Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 9 Feb 2021 17:12:41 +0100
From:   David Sterba <dsterba@suse.cz>
To:     Pan Bian <bianpan2016@163.com>
Cc:     David Sterba <dsterba@suse.com>, Fabian Frederick <fabf@skynet.be>,
        Al Viro <viro@zeniv.linux.org.uk>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/affs: release old buffer head on error path
Message-ID: <20210209161240.GV1993@suse.cz>
Reply-To: dsterba@suse.cz
Mail-Followup-To: dsterba@suse.cz, Pan Bian <bianpan2016@163.com>,
        David Sterba <dsterba@suse.com>, Fabian Frederick <fabf@skynet.be>,
        Al Viro <viro@zeniv.linux.org.uk>, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210120085113.118984-1-bianpan2016@163.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210120085113.118984-1-bianpan2016@163.com>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)
Precedence: bulk

On Wed, Jan 20, 2021 at 12:51:13AM -0800, Pan Bian wrote:
> The reference count of the old buffer head should be decremented on path
> that fails to get the new buffer head.
> 
> Fixes: 6b4657667ba0 ("fs/affs: add rename exchange")
> Signed-off-by: Pan Bian <bianpan2016@163.com>

Thanks, added to affs branch. The fix is not that urgent for 5.11 so
I'll send it for the 5.12 merge window. I've added the stable tag so
it'll propagate to 4.14+.