Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965166AbWIVVv2 (ORCPT ); Fri, 22 Sep 2006 17:51:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965167AbWIVVv2 (ORCPT ); Fri, 22 Sep 2006 17:51:28 -0400 Received: from smtp.osdl.org ([65.172.181.4]:21997 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S965166AbWIVVv2 (ORCPT ); Fri, 22 Sep 2006 17:51:28 -0400 Date: Fri, 22 Sep 2006 14:51:20 -0700 From: Judith Lebzelter To: Linus Torvalds Cc: Linux Kernel Mailing List , dale@farnsworth.org Subject: Re: Arrr! Linux 2.6.18 Message-ID: <20060922215120.GD23169@shell0.pdx.osdl.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1087 Lines: 32 > > Dale Farnsworth: > mv643xx_eth: Unmap DMA buffers in receive path > In OSDL's automated cross-compile for powerpc64, kernel 2.6.18 had this unexpected error: drivers/net/mv643xx_eth.c: In function 'mv643xx_eth_receive_queue': drivers/net/mv643xx_eth.c:388: error: 'RX_SKB_SIZE' undeclared (first use in this function) Here is a patch that stops the error. Judith Lebzelter OSDL --- drivers/net/mv643xx_eth.c.old 2006-09-22 11:22:47.951049416 -0700 +++ drivers/net/mv643xx_eth.c 2006-09-22 11:23:17.787625304 -0700 @@ -385,7 +385,7 @@ struct pkt_info pkt_info; while (budget-- > 0 && eth_port_receive(mp, &pkt_info) == ETH_OK) { - dma_unmap_single(NULL, pkt_info.buf_ptr, RX_SKB_SIZE, + dma_unmap_single(NULL, pkt_info.buf_ptr, ETH_RX_SKB_SIZE, DMA_FROM_DEVICE); mp->rx_desc_count--; received_packets++; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/