Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1612779458-70938-1-git-send-email-jiapeng.chong@linux.alibaba.com>
In-Reply-To: <1612779458-70938-1-git-send-email-jiapeng.chong@linux.alibaba.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Tue, 9 Feb 2021 14:41:55 -0500
Message-ID: <CADnq5_MBY3nx+RmzgigfbBQ05KLRq6UHyCW0eoqfNQRAwd6g_A@mail.gmail.com>
Subject: Re: [PATCH] drm/radeon: Simplify bool comparison
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     "Deucher, Alexander" <alexander.deucher@amd.com>,
        Dave Airlie <airlied@linux.ie>,
        LKML <linux-kernel@vger.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Christian Koenig <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Applied.  Thanks!

Alex

On Mon, Feb 8, 2021 at 5:17 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> Fix the following coccicheck warning:
>
> ./drivers/gpu/drm/radeon/rs690.c:190:6-35: WARNING: Comparison to bool.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/gpu/drm/radeon/rs690.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/rs690.c b/drivers/gpu/drm/radeon/rs690.c
> index c296f94..7bc302a 100644
> --- a/drivers/gpu/drm/radeon/rs690.c
> +++ b/drivers/gpu/drm/radeon/rs690.c
> @@ -187,7 +187,7 @@ static void rs690_mc_init(struct radeon_device *rdev)
>                 /* FastFB shall be used with UMA memory. Here it is simply disabled when sideport
>                  * memory is present.
>                  */
> -               if (rdev->mc.igp_sideport_enabled == false && radeon_fastfb == 1) {
> +               if (!rdev->mc.igp_sideport_enabled && radeon_fastfb == 1) {
>                         DRM_INFO("Direct mapping: aper base at 0x%llx, replaced by direct mapping base 0x%llx.\n",
>                                         (unsigned long long)rdev->mc.aper_base, k8_addr);
>                         rdev->mc.aper_base = (resource_size_t)k8_addr;
> --
> 1.8.3.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel