Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp865796pxb; Tue, 9 Feb 2021 14:56:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJxyp9MPXl3+dePT5KM5Mw0ga2IPovo36L5ss+/bLNpg483G9LN9xn7Jn8aFIgxxksMrHBjQ X-Received: by 2002:a17:906:1355:: with SMTP id x21mr24783616ejb.53.1612911382132; Tue, 09 Feb 2021 14:56:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612911382; cv=none; d=google.com; s=arc-20160816; b=tlTHwLSE2aI6SdmZsWCWsgO0y3dDaetFNZVGtHCKYvTL74uxUEwcLlI9uo0Q+LjTRt j4aDKfdyUW0u7Ic5kIKtYtLtQKKV/5uTEj2hVYTiGPbxi/GXJCaSnYeHmkEzRezhxDoY djw5gR/CDbee0z5jizHKgX+7jzITz/+rdBUOMmcXybjhvw7/Vf/jqr8P6nvW+GTHKJAr T6MyVOa8RM4oAiwYBnFPocK8C6uO2uZosDC8aJgteyqeSx9EIvehibApNllOO/sq40hj 8BcgFxQmyOkTIV9oV7u8FqGaO+h6c2RANxQg2mVeBoSIFkXqcPrAaax9vqJWZPZJIn7y I8iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=IYclPMhVxuN9ZjGqeCMK45UVqTR6GzVRDadoMxuQnuo=; b=HzoLp5S0ntCU8XZnIuXCgnn17UhmpWWIgIKlG+ZLTHwDDgKg6+/Yjx32m43Xc2j7B2 K/zX8oYCCzweqJMHOFLBoLYa4TZ3YyM97xlc2L0uMur8iGHKQFR2OL71l1nUxitiivkw rUNZev4UF6+W9gZWAUPQFyHzJS60/K6O+kMZThgx8gQOMMCLN3mIig6ABrxZMi5qy6x8 FBu7UdYKofqrNSwK+XRHWRib6LUAKMm7mmC26Vq9COg8ZgSxcNfo/6z2mKvJSnz+JO9A ekVOtVzvDZK4oWV36dLdTq5bUz9nScdHJVj62o5w5gv9piIgCNoU0H5zsd//XTdAo7ia DtfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=rse+ayem; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r26si96625edt.85.2021.02.09.14.55.58; Tue, 09 Feb 2021 14:56:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=rse+ayem; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234613AbhBIWyK (ORCPT + 99 others); Tue, 9 Feb 2021 17:54:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:56780 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233675AbhBITrp (ORCPT ); Tue, 9 Feb 2021 14:47:45 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0584664E85; Tue, 9 Feb 2021 19:46:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1612900001; bh=Tibp+D2Q1fLAWYC0pmdwEcPTKdC9dJtIKxcQZULcsjE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rse+ayemXBSfNdjdOADaJKaOySC6VHwaFAcgRgC6E7VW4kTzQhz08AQptUyzvAm85 QUKn8ECsDODXqY+mzEcjP9BGMyivax4L1/iHNiS+pjMKam7WpgniNCJTkR0RgCvNU9 013T0dhjSmenA7iCcHvpA/HQ0nZdPmWQe8TJN1yA= Date: Tue, 9 Feb 2021 11:46:40 -0800 From: Andrew Morton To: Naoya Horiguchi Cc: linux-mm@kvack.org, Michal Hocko , Oscar Salvador , Tony Luck , Matthew Wilcox , "Aneesh Kumar K.V" , Naoya Horiguchi , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] mm, hwpoison: enable error handling on shmem thp Message-Id: <20210209114640.73a68074f635852c2ce498e6@linux-foundation.org> In-Reply-To: <20210209062128.453814-1-nao.horiguchi@gmail.com> References: <20210209062128.453814-1-nao.horiguchi@gmail.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 9 Feb 2021 15:21:28 +0900 Naoya Horiguchi wrote: > Currently hwpoison code checks PageAnon() for thp and refuses to handle > errors on non-anonymous thps (just for historical reason). We now > support non-anonymou thp like shmem one, so this patch suggests to enable > to handle shmem thps. Fortunately, we already have can_split_huge_page() > to check if a give thp is splittable, so this patch relies on it. Thanks. We're at -rc7 so I think I'll park this one for 5.12-rc1, unless it is more urgent than I believe it to be?