Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: qm3QDZKXVvUz7zK36R1cBmtYWTMjh9MmHmrEqnEf/VtC/ag/YXR087xiBAeOSqr2pPhsBdR/hE
 d16Vo7P0q9cA==
IronPort-SDR: KMBExiMqHPbOmuFWjVF8uvMMKlFrOnZlogo2zHUcOm/4gLUvrr15QrFYyuMFho/oWotwP63h6j
 qaE46oV2PR+w==
Date:   Tue, 9 Feb 2021 13:52:29 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     dsterba@suse.cz, clm@fb.com, josef@toxicpanda.com,
        dsterba@suse.com, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH 0/4] btrfs: Convert kmaps to core page calls
Message-ID: <20210209215229.GC2975576@iweiny-DESK2.sc.intel.com>
References: <20210205232304.1670522-1-ira.weiny@intel.com>
 <20210209151123.GT1993@suse.cz>
 <20210209110931.00f00e47d9a0529fcee2ff01@linux-foundation.org>
 <20210209205249.GB2975576@iweiny-DESK2.sc.intel.com>
 <20210209131103.b46e80db675fec8bec8d2ad1@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210209131103.b46e80db675fec8bec8d2ad1@linux-foundation.org>
User-Agent: Mutt/1.11.1 (2018-12-01)
Precedence: bulk

On Tue, Feb 09, 2021 at 01:11:03PM -0800, Andrew Morton wrote:
> > > 
> > > It would be best to merge [1/4] via the btrfs tree.  Please add my
> > > 
> > > Acked-by: Andrew Morton <akpm@linux-foundation.org>
> > > 
> > > 
> > > Although I think it would be better if [1/4] merely did the code
> > > movement.  Adding those BUG_ON()s is a semantic/functional change and
> > > really shouldn't be bound up with the other things this patch series
> > > does.
> > 
> > I proposed this too and was told 'no'...
> > 
> > <quote>
> > If we put in into a separate patch, someone will suggest backing out the
> > patch which tells us that there's a problem.
> > </quote>
> > 	-- https://lore.kernel.org/lkml/20201209201415.GT7338@casper.infradead.org/
> 
> Yeah, no, please let's not do this.  Bundling an offtopic change into
> [1/4] then making three more patches dependent on the ontopic parts of
> [1/4] is just rude.
> 
> I think the case for adding the BUG_ONs can be clearly made.  And that
> case should at least have been clearly made in the [1/4] changelog!
> 
> (Although I expect VM_BUG_ON() would be better - will give us sufficient
> coverage without the overall impact.)

I'm ok with VM_BUG_ON()

> 
> Let's please queue this up separately.

Ok can I retain your Ack on the move part of the patch?  Note that it does
change kmap_atomic() to kmap_local_page() currently.

Would you prefer a separate change for that as well?

Ira

PS really CC'ing Matthew now...