Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp925609pxb; Tue, 9 Feb 2021 16:55:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJwrMmFUM538w71gwBw1igeQ69Idm0pT/w69vRb72ufIoo+z7ulLRyrajOpt4R4gExc5ppsg X-Received: by 2002:aa7:c6d9:: with SMTP id b25mr866626eds.84.1612918552127; Tue, 09 Feb 2021 16:55:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612918552; cv=none; d=google.com; s=arc-20160816; b=i0ForTLyciuMRm/McClzIOgooDnJtsN6ttC65ca+zjTTTLwwHBnzxpm8De51MC/XwL TmQYu9ty4MPj0dQy1ICy6c6Ge7WV4etyR4RdTBslCI7heLKGhBS17u1jEcLDwSfMbcqT jicPlLouEb2S1HXFch6JIIdU9sqmhB3YNLJ504rD4NZyiNnFG7zBYxJNCioeUAH7VpmC NiD4tC0qAMGKmT92EfHf9jo7nYMWREAEXtU7oyvwWKWy0tQ28lbyRmdlO9ZqIRwivT6o lSASsCCQom4RPjdHgPPzlJcDAdx6+bqVGMMXPhv8H5gniK2kht+yNtH8yjiQh4jdwBvV ECZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=wkvjro8HLT8758q6c/IrW0/M89MKOXnnr7CjW2bp3D8=; b=jy8XV2bqJ9FAQy/qD1d2B3G3LJ8xveHg62ixRrBr9OFbEj4MQsbpXj6bnt3okY8i6t RKL1+UXBBX6V6qEVn1khrI0c88L33TNeCBjNW0P3dRaXlVIrDGSwQDUSLoe8wlfnT17H j273lz9yBgBv58okZAePHfoIc2C+YzHQmx9AFAV539REyUbEK6AYQkuE3PxoKBl8bLg3 rhuRy1R2Q1Rdr4pCPOUMHv9BR4DuLY94K9eySjvcPCdSseVyah5i2aeVvpEjHUD3mbPx CEsDZbGYo88CZqm3Eq0pEhE2TKz337hITYato5YDtc1Yc/EexiB+XACnir1OhwcfqXCD Y6Yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=l4OVeW6U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y10si315316ede.335.2021.02.09.16.55.28; Tue, 09 Feb 2021 16:55:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=l4OVeW6U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233872AbhBJAxk (ORCPT + 99 others); Tue, 9 Feb 2021 19:53:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:55452 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233983AbhBIWMQ (ORCPT ); Tue, 9 Feb 2021 17:12:16 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 83C3264EDB; Tue, 9 Feb 2021 21:58:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1612907919; bh=3OazZLnMyWfzCFzoLzcmJx+KxLTa7Ra6qrPelD5PAJc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=l4OVeW6UO3eZoL6HdhnLEntkfsJha1QB0Hp3JUXgAmjhCkCRQJbRtIuNUfAopYcAP iKHbxIeIejc4/QlW3XVUd6L0ItJLgOIunN9QXjyxizis4aHpxAoUSnVS4gKGlKYZHi SyxhdbawLDcAUoTnpY4g/cvV9GR6ocECy3THL5A0= Date: Tue, 9 Feb 2021 13:58:37 -0800 From: Andrew Morton To: Ira Weiny Cc: dsterba@suse.cz, clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Matthew Wilcox Subject: Re: [PATCH 0/4] btrfs: Convert kmaps to core page calls Message-Id: <20210209135837.055cfd1df4e5829f2da6b062@linux-foundation.org> In-Reply-To: <20210209215229.GC2975576@iweiny-DESK2.sc.intel.com> References: <20210205232304.1670522-1-ira.weiny@intel.com> <20210209151123.GT1993@suse.cz> <20210209110931.00f00e47d9a0529fcee2ff01@linux-foundation.org> <20210209205249.GB2975576@iweiny-DESK2.sc.intel.com> <20210209131103.b46e80db675fec8bec8d2ad1@linux-foundation.org> <20210209215229.GC2975576@iweiny-DESK2.sc.intel.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 9 Feb 2021 13:52:29 -0800 Ira Weiny wrote: > > > > Let's please queue this up separately. > > Ok can I retain your Ack on the move part of the patch? I missed that. > Note that it does change kmap_atomic() to kmap_local_page() currently. > > Would you prefer a separate change for that as well? Really that should be separated out as well, coming after the move, to make it more easily reverted. With a standalone changlog for this. All a bit of a pain, but it's best in the long run.