Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 10 Feb 2021 08:50:51 +1100
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Jessica Yu <jeyu@kernel.org>
Cc:     Christoph Hellwig <hch@lst.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Masahiro Yamada <masahiroy@kernel.org>
Subject: Re: linux-next: build failure after merge of the modules tree
Message-ID: <20210210085051.7fb951d1@canb.auug.org.au>
In-Reply-To: <YCKnRPRTDyfGxnBC@gunter>
References: <20210209210843.3af66662@canb.auug.org.au>
        <YCKnRPRTDyfGxnBC@gunter>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/mF5sT4DfCLMx5cOaN5Q+QBj";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk

--Sig_/mF5sT4DfCLMx5cOaN5Q+QBj
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Jessica,

On Tue, 9 Feb 2021 16:16:20 +0100 Jessica Yu <jeyu@kernel.org> wrote:
>
> Hmm, these errors don't look like it's related to that particular commit.=
 I was

I found this commit by bisection and then tested by reverting it.

Before this commit, CONFIG_TRIM_UNUSED_KSYMS would not be set in the
allyesconfig build because CONFIG_UNUSED_SYMBOLS was set.  After this
commit, CONFIG_TRIM_UNUSED_KSYMS will be set in the allyesconfig build.

> able to reproduce these weird autoksym errors even without any modules-ne=
xt
> patches applied, and on a clean v5.11-rc7 tree. To reproduce it,
> CONFIG_TRIM_UNUSED_KSYMS needs to be enabled. I guess that's why we run i=
nto
> these errors with allyesconfig. I used a gcc-7 ppc64le cross compiler and=
 got
> the same compiler warnings. It seems to not compile on powerpc properly b=
ecause
> it looks like some symbols have an extra dot "." prefix, for example in
> kthread.o:
>=20
>     168: 0000000000000318    24 NOTYPE  GLOBAL DEFAULT    6 kthread_creat=
e_worker
>     169: 0000000000001d90   104 FUNC    GLOBAL DEFAULT    1 .kthread_crea=
te_worker
>     170: 0000000000000330    24 NOTYPE  GLOBAL DEFAULT    6 kthread_creat=
e_worker_on_cpu
>     171: 0000000000001e00    88 FUNC    GLOBAL DEFAULT    1 .kthread_crea=
te_worker_on_cpu
>     172: 0000000000000348    24 NOTYPE  GLOBAL DEFAULT    6 kthread_queue=
_work
>     173: 0000000000001e60   228 FUNC    GLOBAL DEFAULT    1 .kthread_queu=
e_work
>=20
> So I suppose this dot prefix is specific to powerpc. From the ppc64 elf a=
bi docs:
>=20
>      Symbol names with a dot (.) prefix are reserved for holding entry po=
int
>      addresses. The value of a symbol named ".FN", if it exists, is the e=
ntry point
>      of the function "FN".
>=20
> I guess the presence of the extra dot symbols is confusing
> scripts/gen_autoksyms.sh, so we get the dot symbols in autoksyms.h, which=
 the
> preprocessor doesn't like. I am wondering how this was never caught until=
 now
> and also now curious if this feature was ever functional on powerpc..

Which feature?

--=20
Cheers,
Stephen Rothwell

--Sig_/mF5sT4DfCLMx5cOaN5Q+QBj
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmAjA7sACgkQAVBC80lX
0Gzwlgf/ctA6cRjr3PycwX776JNl/lXhgq80w0pR7pFpO8OABd7QWDN+9Pb2blnZ
tfsyhdvSJdCqfF5+iTdZudJOHYLaG572NTep620O3VBxAa6EVOErqSzH4tDlXC8h
bj4cfZEzd63xGnNh+F/c5szn9k0A5tEJG3fFP/XKYUUbEI74Uu0nzJu/8NhuDPeJ
kV+9lbT29f4x+OnBGW8Fw/NomyikgMSmxl+ogiqhtDols++QljYLBiHgMqzZoD6v
F7tydwMWr50nO+0+su30kk08cnW0qivaqxLJzdaGiDk8Px03eGCs5+NUk0kJFGg6
01/1bjeGuD752z9qVqXE1HixU1CNrw==
=RQeI
-----END PGP SIGNATURE-----

--Sig_/mF5sT4DfCLMx5cOaN5Q+QBj--