Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Song Liu <songliubraving@fb.com>
To:     Joe Perches <joe@perches.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH v3] checkpatch: do not apply "initialise globals to 0"
 check to BPF progs
Thread-Topic: [PATCH v3] checkpatch: do not apply "initialise globals to 0"
 check to BPF progs
Thread-Index: AQHW/xIkjCL+hhYrfku+4kePe6r7yqpQLT8AgAAMdgCAAAPbAIAAFsyA
Date:   Tue, 9 Feb 2021 21:19:30 +0000
Message-ID: <3DA4D57D-C7A1-484B-B7AE-3F1DB958F4C8@fb.com>
References: <20210209183343.3929160-1-songliubraving@fb.com>
 <2b41e46fcf909bd67a578524107214fe4b1eeede.camel@perches.com>
 <4D649CDF-A738-468E-AD00-8A64DDB11D1D@fb.com>
 <fcf4561a8ab24bc4b22c536c55614fa0f0a924ec.camel@perches.com>
In-Reply-To: <fcf4561a8ab24bc4b22c536c55614fa0f0a924ec.camel@perches.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <E8140CF68B4F37498FCC247CEED91721@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a0f68fcf-36bf-4ef6-f1d4-08d8cd4063b6
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2021 21:19:30.6240
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DPST97gYnmMMAtQkgQx6v2/iDXeaxIg5I1swCypYra0P755KbtGpkmWQ+4JZODQfKAHb5pu1QjP0hNGqFbyqEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR15MB3668
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737
 definitions=2021-02-09_07:2021-02-09,2021-02-09 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 clxscore=1015 spamscore=0
 phishscore=0 priorityscore=1501 impostorscore=0 mlxscore=0
 lowpriorityscore=0 malwarescore=0 adultscore=0 bulkscore=0 mlxlogscore=999
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2102090108
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Feb 9, 2021, at 11:57 AM, Joe Perches <joe@perches.com> wrote:
>=20
> On Tue, 2021-02-09 at 19:44 +0000, Song Liu wrote:
>>> On Feb 9, 2021, at 10:59 AM, Joe Perches <joe@perches.com> wrote:
>>> On Tue, 2021-02-09 at 10:33 -0800, Song Liu wrote:
>>>> BPF programs explicitly initialise global variables to 0 to make sure
>>>> clang (v10 or older) do not put the variables in the common section.
>>>> Skip "initialise globals to 0" check for BPF programs to elimiate erro=
r
>>>> messages like:
>>>>=20
>>>>     ERROR: do not initialise globals to 0
>>>>     #19: FILE: samples/bpf/tracex1_kern.c:21:
> []
>>>> ---
>>>> Changes v2 =3D> v3:
>>>>   1. Fix regex.
>>>=20
>>> Unfortunately, this has broken regexes...
>>>=20
>>>> Changes v1 =3D> v2:
>>>>   1. Add function exclude_global_initialisers() to keep the code clean=
.
>>>> ---
>>>>  scripts/checkpatch.pl | 12 +++++++++++-
>>>>  1 file changed, 11 insertions(+), 1 deletion(-)
>>>>=20
>>>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>>> []
>>>> @@ -2428,6 +2428,15 @@ sub get_raw_comment {
>>>>  	return $comment;
>>>>  }
>>>>=20
>>>> +sub exclude_global_initialisers {
>>>> +	my ($realfile) =3D @_;
>>>> +
>>>> +	# Do not check for BPF programs (tools/testing/selftests/bpf/progs/*=
.c, samples/bpf/*_kern.c, *.bpf.c).
>>>> +	return $realfile =3D~ m@/^tools\/testing\/selftests\/bpf\/progs\/.*\=
.c@ ||
>>>=20
>>> You don't need to escape the / when using m@@, and this doesn't work
>>> given the leading / after @, and it should use a trailing $
>>>=20
>>> 	return $realfile =3D~ m@^tools/testing/selftests/bpf/progs/.*\.c$@ ||
>>>=20
>>>> +		$realfile =3D~ m@^samples\/bpf\/.*_kern.c@ ||
>>>=20
>>> This is still missing an escape on the . before c@, and there's no
>>> trailing $ between c and @
>>>=20
>>> 		$realfile =3D~ m@^samples/bpf/.*_kern\.c$@ ||
>>>=20
>>>> +		$realfile =3D~ m@/bpf/.*\.bpf\.c$@;
>>>=20
>>> I believe I showed the correct regexes in my earlier reply.
>>=20
>> Just to be sure I got everything correct, does the follow look right?
>>=20
>>         return $realfile =3D~ m@^tools/testing/selftests/bpf/progs/.*\.c=
$@ ||
>>                 $realfile =3D~ m@^samples/bpf/.*_kern\.c$@ ||
>>                 $realfile =3D~ m@/bpf/.*\.bpf\.c$@;
>>=20
>> Thanks,
>> Song
>=20
> Looks right, you tell me though, this is the current -next file list
> for what is being suggested:
>=20
> $ git ls-files | \
>  perl -n -e 'print $_ if ($_ =3D~ m@^tools/testing/selftests/bpf/progs/.*=
\.c$@ ||
>                $_ =3D~ m@^samples/bpf/.*_kern\.c$@ ||
>                $_ =3D~ m@/bpf/.*\.bpf\.c$@);'

Thanks! This looks great.=20

Song

[...]