Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH][RESEND] lib/vsprintf: make-printk-non-secret printks all
 addresses as unhashed
To:     Marco Elver <elver@google.com>
Cc:     Petr Mladek <pmladek@suse.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        linux-kernel@vger.kernel.org, vbabka@suse.cz, linux-mm@kvack.org,
        willy@infradead.org, akpm@linux-foundation.org,
        torvalds@linux-foundation.org, roman.fietze@magna.com,
        keescook@chromium.org, john.ogness@linutronix.de,
        akinobu.mita@gmail.com, glider@google.com, andreyknvl@google.com
References: <20210202213633.755469-1-timur@kernel.org>
 <YCMFzCz8ootub9pH@elver.google.com>
From:   Timur Tabi <timur@kernel.org>
Message-ID: <2de3a189-adca-4954-e2a3-c79fbe3eee96@kernel.org>
Date:   Tue, 9 Feb 2021 16:15:20 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <YCMFzCz8ootub9pH@elver.google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2/9/21 3:59 PM, Marco Elver wrote:
> Would it be reasonable to make this non-static? Or somehow make it
> possible to get this flag from other subsystems?
> 
> There are other places in the kernel that dump sensitive data such as
> registers. We'd like to be able to use 'debug_never_hash_pointers' to
> decide if our debugging tools can dump registers etc. What we really
> need is info if the kernel is in debug mode and we can dump all kinds of
> sensitive info; debug_never_hash_pointers is would be a good enough
> proxy for that.

The next version of my patch (coming soon) will export the symbol.  It's 
intended for test_printf, but if you think it can be used by others, so 
much the better.