Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp951754pxb; Tue, 9 Feb 2021 17:48:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJzTdz/ZI3ifs+IvOTBXx8YsfLHw5UFiNLF0YNhxMfWfgIcYLDz5PYb7bm15d54XtD2uWkZa X-Received: by 2002:a17:906:15c7:: with SMTP id l7mr598446ejd.226.1612921686770; Tue, 09 Feb 2021 17:48:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612921686; cv=none; d=google.com; s=arc-20160816; b=aqVTJrbZV6O23XipHzSMyeuagRYkw0r7qHbSeqLFg/SKfUv/g7FDVUSgKbnSrn00FX gdICV5pBjshHr6lWrblmqVm+8QaDw7kxMtL1n1zJbGm/kCuhLqxFWjGSqxJ2LDHWZoPm HknLHZr84pBH2Hd/KpIwN5V4heh+WgH+XGy99dACTTZ8cuiXnSV8Sp1f5fk0gmK6+fxe yoI/s3Z0m2JfzWLaixB88THhxlEO+CIUgcGEp3FoUj4q7QJwmIze7vHk6mHJ1J5PC2r9 LN5BBm3/L3fhVgmCPAYCuejU2coDBAhvZ8QPEb4s55PKEU/FBenSPxhAptlMgA04dwHK 35yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=csLurx4QKHks9x8W7o/+52yM1zn3e2mQVu/1eqS7HXU=; b=fORGaZXP/YEMPVZlOYOqvKnoqSEkhphlqZOhlzd94w8ldQ4uKjic6EZD8jrGU4ElMr ft29DRzfH2GWgj4XwnXqhKR+I+PdEsSS90o2qv3nOpywxnF024VxqAfKRbdO0BG8dQCP Yzz+OFEvFahulAbANmmm8OnwLyt3QtrBdbAD1lqK4qZwCR2s4yUfZIeI1T7BNNBDxmTE eT4M2m24yC0CLrhrkkkebCTt4hqjyqGOtVGbCqrYvtw5qfh+VyqoIMIiaficIhyFUZrV cj24XOiNbN1fu45bUrYF6PJdpCQ+Ts1JQjp40oqgbQh9JdGXg40yjir1Ql1uzwRZzwrJ azKA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siol.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ce27si384698edb.213.2021.02.09.17.47.43; Tue, 09 Feb 2021 17:48:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siol.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234664AbhBJBqv (ORCPT + 99 others); Tue, 9 Feb 2021 20:46:51 -0500 Received: from mailoutvs18.siol.net ([185.57.226.209]:33226 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S234576AbhBJABx (ORCPT ); Tue, 9 Feb 2021 19:01:53 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Zimbra) with ESMTP id 050A3523405; Tue, 9 Feb 2021 18:59:06 +0100 (CET) X-Virus-Scanned: amavisd-new at psrvmta12.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta12.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id kqUDlYvveiwt; Tue, 9 Feb 2021 18:59:05 +0100 (CET) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Zimbra) with ESMTPS id A0A3D5231C9; Tue, 9 Feb 2021 18:59:05 +0100 (CET) Received: from kista.localdomain (cpe-86-58-58-53.static.triera.net [86.58.58.53]) (Authenticated sender: 031275009) by mail.siol.net (Zimbra) with ESMTPSA id 9540D523182; Tue, 9 Feb 2021 18:59:03 +0100 (CET) From: Jernej Skrabec To: mripard@kernel.org, wens@csie.org Cc: mturquette@baylibre.com, sboyd@kernel.org, airlied@linux.ie, daniel@ffwll.ch, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sunxi@googlegroups.com Subject: [PATCH v3 0/5] sunxi: fix H6 HDMI related issues Date: Tue, 9 Feb 2021 18:58:55 +0100 Message-Id: <20210209175900.7092-1-jernej.skrabec@siol.net> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Over the year I got plenty of reports of troubles with H6 HDMI signal. Sometimes monitor flickers, sometimes there was no image at all and sometimes it didn't play well with AVR. It turns out there are multiple issues. Patch 1 fixes clock issue, which didn't adjust parent rate, even if it is allowed to do so. Patch 2 adds polarity config in tcon1. This is seemingly not needed for pre-HDMI2 controllers, although BSP drivers set it accordingly every time. It turns out that HDMI2 controllers often don't work with monitors if polarity is not set correctly. Patch 3 always set clock rate for HDMI controller. Patch 4 fixes H6 HDMI PHY settings. Patch 5 fixes comment and clock rate limit (wrong reasoning). Please take a look. Best regards, Jernej Changes from v2: - use clk_hw_can_set_rate_parent() directly instead of checking flags Changes from v1: - collected Chen-Yu tags (except on replaced patch 4) - Added some comments in patch 2 - Replaced patch 4 (see commit log for explanation) Jernej Skrabec (5): clk: sunxi-ng: mp: fix parent rate change flag check drm/sun4i: tcon: set sync polarity for tcon1 channel drm/sun4i: dw-hdmi: always set clock rate drm/sun4i: Fix H6 HDMI PHY configuration drm/sun4i: dw-hdmi: Fix max. frequency for H6 drivers/clk/sunxi-ng/ccu_mp.c | 2 +- drivers/gpu/drm/sun4i/sun4i_tcon.c | 25 +++++++++++++++++++++++++ drivers/gpu/drm/sun4i/sun4i_tcon.h | 6 ++++++ drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 10 +++------- drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h | 1 - drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c | 26 +++++++++----------------- 6 files changed, 44 insertions(+), 26 deletions(-) -- 2.30.0