Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp957592pxb; Tue, 9 Feb 2021 18:00:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJzjvHtxlcS9TWXo08f+XXhM0nBxIwF3KWn4icvr/GbUPQKxzvnKmByfF4uBLAd5z1znMoND X-Received: by 2002:a17:907:1692:: with SMTP id hc18mr629683ejc.244.1612922414841; Tue, 09 Feb 2021 18:00:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612922414; cv=none; d=google.com; s=arc-20160816; b=VmzrtY/76OHUQQEwe1VpxNKCd30ZrJwbBFqSb5zNpk3acdysIOi9is0vkESfj9Xw1T Rvq1xS7TexkfB4ltquM5Yds95p85aU1tOHX69GwTsb0HOn+N60xcCkE4rzuCr4RM+yeK xh/Rp0MdJFMP3ppIzwrILpea9d091RW2TfH4W+FwtFFH/wKsDwNYgXpw//1crmjPS/m4 GBaPFuvS99ESsr2B8bHspUnhbnEDXi9jBmVvOsyNooJDH+6Tsmn/qH83BvCM8I9IZym8 Z2OVT7nUisIBg2bcsHlWNhCBGKtavJfsZ/mW6Kge8QSrxm3dzdhJFjGy8+JHFOqipe3T TxXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=X45YGhvSSKINz38Za1Kkw3oOXRPeq40EClkO0mkNfk0=; b=hZez01j78ICEOvPOFu8JeRenQFGZuCV0avFysFGVhpHwTaquB5EmL5pAmluat08JBa eUa9hPfGwh6cA1QIWgn8hbc07U2b7KSFqTif+CfQdQb1+EwpypP1168O4wRnUfqMZwoo CgizPO1ErZ4pPc7yVbKBWTA45bFEkGEeV1ekfMdwLggwm0iI/2+JxDQjU0IpSmp/gXjo i06WIkYGny+kSojWRwgaO6HGB5NWZuXO3dvp+brgbWLk064YZY/jLjUTfZBB/vWnm3zN eZc6JTNO/Pg7Qv/78GSZJw1pvouju6+qN8YPVZyNFmyfA2ftKDy6dCrnNJECW8VPK2zR Cwvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="bB0qQvW/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ce20si410726edb.138.2021.02.09.17.59.50; Tue, 09 Feb 2021 18:00:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="bB0qQvW/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235254AbhBJB56 (ORCPT + 99 others); Tue, 9 Feb 2021 20:57:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234889AbhBJAYz (ORCPT ); Tue, 9 Feb 2021 19:24:55 -0500 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19563C061574 for ; Tue, 9 Feb 2021 16:24:14 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id j11so220439plt.11 for ; Tue, 09 Feb 2021 16:24:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=X45YGhvSSKINz38Za1Kkw3oOXRPeq40EClkO0mkNfk0=; b=bB0qQvW/EF9biTCYsZRdZp2t1wzgg8HcyPgCsaAdgn6UYufvqz+ZPo/l/TZvkhElhh VtlZd00G2ZbIppI7LRcrFM9Q9bJsIN+sBsu1mE9b4IGIGWVhzm4xRylRNXTKUXTpm24l t4L8GzLd+l2EcucPBlmtuugylzY/W1hW5+1eg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=X45YGhvSSKINz38Za1Kkw3oOXRPeq40EClkO0mkNfk0=; b=roy1HSaHRiKdz3J3UPqm/P/BazAADhIMsH9xc5QYCC257AO9kF1INmRjFbluoqyCXa Ce4exhVaa2MhJivssSVDh5RkG3vy6otkgzNupPreEeg372u7rbCIv6CPgGvz1mv+YlzM C3fXrpd5RtKxZi72/kso3gembpTLEmDDVd6jMxHTvp5IRuPEvfkopjA2Dp4cmaQyvg1M 1M8vPZYgR1XUOQA/tfNlgdVozKsLXHFwxrF9zU+BTeeWW/k90/ZqQFWoFho5pPnc/33E YN7sawv6GiAKBltsi7bWRsSwpKO9BV1lOQCS0kxsQo9WJC/I6DAC7fUielJ2sJDAHi5x nYEA== X-Gm-Message-State: AOAM5313de6l4e4qsgROgu0ljksPCSkNuTnKDCFhH5Adx/3LvMADAKIF PRXZcxn4DPqLVFGCt/unMMzjAg== X-Received: by 2002:a17:90b:354:: with SMTP id fh20mr483392pjb.122.1612916653657; Tue, 09 Feb 2021 16:24:13 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id c18sm94664pfj.58.2021.02.09.16.24.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Feb 2021 16:24:12 -0800 (PST) Date: Tue, 9 Feb 2021 16:24:11 -0800 From: Kees Cook To: Timur Tabi Cc: Vlastimil Babka , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , linux-kernel@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, roman.fietze@magna.com, john.ogness@linutronix.de, akinobu.mita@gmail.com Subject: Re: [PATCH][RESEND] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed Message-ID: <202102091623.834390BBF9@keescook> References: <20210202213633.755469-1-timur@kernel.org> <3baace45-38af-a59b-c376-9a4c39a17b2d@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 05, 2021 at 12:25:22PM -0600, Timur Tabi wrote: > I can extend make-printk-non-secret to %pK if everyone agrees. Let's just leave those alone. There is already a toggle for that in /proc. -- Kees Cook