Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp972615pxb; Tue, 9 Feb 2021 18:28:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJwD0Pn+ttJg+WgMqfF4XiTSadMDseaSez90GWN85g5AI7Qnl7hDVVvw9fQT0Vxr/SecOo/p X-Received: by 2002:a17:906:c051:: with SMTP id bm17mr635097ejb.493.1612924108735; Tue, 09 Feb 2021 18:28:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612924108; cv=none; d=google.com; s=arc-20160816; b=UTIcpopAagET+QZCPgDP094P+FJ8xN8WG2gjCBHIvYRwPonXxIpveCnZSkVChciJYH CxELS3ZKbym5hjyw648z1f01ezWIo0quN4ocOddPSA4ayuhdZlnFxJ6EELyyLmELGm97 /1nTeJAhA5FKCXm+Ksa3gWlrxbRN92982fVgvIPKdWBubn6EbDDtu44uNfeeUCAj4NMk PRdwLy03UAh/bUdGyDtR2wDAaUr8qG7Kg1nflyKYItuhKLusq9HJjS/vVvIto0U4+CHJ /GT98HpndcYr9VyS/A1P39mu9pnSYXMbolDJaMBrZ6vy+5K9AtvCnW5aZjHDc+MO6b6p A5Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=uG2z5Tv2o8nNN5cUTCUpHTcgzDpSeYpBBP0HxD2EXbc=; b=AUBez3MMxcyMzU/Bu303qiQFEWLNR9C52uhCAbNi/igI5Nd+b6vRloOjl+5EzJPsND XJHQdl0FwpIZlHLTPFnjd4/Fb+An9ssG5aTW6RrVgxBK/cx3gwqNSDgpT0deIsrzd/SE 91otuhkSMTywZciNMITIDF8gLkChyEp0pQHoo7mQwb6IDLGQ/qOWlMjpuhtR1EmZdLG5 NS2DDPt/eHRVO3tUFfozuEJAEBZC76Tk8/yPkudXwebzPSANWEKLHZ5DPcC/+pBEIpiU DWpUOoKqK3MEHOf6D/s5pFIsZ3CgX73AX/mVXSk5EBvmzpf9ixOo1gbYPBMAGez7DyzH CryA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g10si299022ejw.681.2021.02.09.18.28.05; Tue, 09 Feb 2021 18:28:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234581AbhBJC0s (ORCPT + 99 others); Tue, 9 Feb 2021 21:26:48 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:59148 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235225AbhBJB5t (ORCPT ); Tue, 9 Feb 2021 20:57:49 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1l9ekd-005Dpr-KO; Wed, 10 Feb 2021 02:57:07 +0100 Date: Wed, 10 Feb 2021 02:57:07 +0100 From: Andrew Lunn To: Michael Walle Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Heiner Kallweit , Russell King , "David S . Miller" , Jakub Kicinski Subject: Re: [PATCH net-next 2/9] net: phy: icplus: use PHY_ID_MATCH_EXACT() for IP101A/G Message-ID: References: <20210209164051.18156-1-michael@walle.cc> <20210209164051.18156-3-michael@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210209164051.18156-3-michael@walle.cc> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 09, 2021 at 05:40:44PM +0100, Michael Walle wrote: > According to the datasheet of the IP101A/G there is no revision field > and MII_PHYSID2 always reads as 0x0c54. Use PHY_ID_MATCH_EXACT() then. > > Signed-off-by: Michael Walle Lets hope the datasheet is correct and up to date, because this could cause a regression if wrong. Reviewed-by: Andrew Lunn Andrew